From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] gfxmenu relative path in "file" component of images
Date: Wed, 20 Jan 2010 23:51:05 +0100 [thread overview]
Message-ID: <4B5788D9.3060401@gmail.com> (raw)
In-Reply-To: <20100120223704.GA25465@thorin>
[-- Attachment #1: Type: text/plain, Size: 795 bytes --]
Robert Millan wrote:
> This makes it possible to use relative paths in the "file" component of
> gfxmenu images. I've tested that it works, but I'd appreciate if someone
> more familiar with gfxmenu can review it.
>
+ static const char *theme_dir = NULL;
Add a member to grub_gui_image_t rather than using a static variable
+ theme_dir = value;
Use appropriate grub_strdup and free in _destroy function.
+ return load_image (self, absvalue);
absvalue isn't freeed
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 293 bytes --]
prev parent reply other threads:[~2010-01-20 22:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 22:37 [PATCH] gfxmenu relative path in "file" component of images Robert Millan
2010-01-20 22:51 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5788D9.3060401@gmail.com \
--to=phcoder@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.