From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [Patch 1/2] CLD: export a common timer implementation
Date: Wed, 20 Jan 2010 20:52:33 -0500
Message-ID: <4B57B361.5040203@garzik.org>
References: <20100116000758.447e73d9@redhat.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=oItaiu8ngGTZ+lx1jZEkV130W2fnhV+3xYetiJLUXAw=;
        b=SKbP0xlJJ6EKUOEKZitYxFb6YLtPJ7fYi81YdpzZKnq3VmiB2GyY3GnPtgt9+tYRx+
         UF+GjMcPGNGOg44s9puMRkrVaSrZ+whXoaNKNUr1Jnm/uzGR6q51/oSYUBBmAS/+5x+O
         63Qi2tKV+KeeYJSLq1n2hV5275rPuYNBAZaL8=
In-Reply-To: <20100116000758.447e73d9@redhat.com>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>

On 01/16/2010 02:07 AM, Pete Zaitcev wrote:
> diff --git a/lib/Makefile.am b/lib/Makefile.am
> index 68be429..dfae79a 100644
> --- a/lib/Makefile.am
> +++ b/lib/Makefile.am
> @@ -9,14 +9,14 @@ LINK = $(LIBTOOL) --mode=link $(CC) $(CFLAGS) $(LDFLAGS) -o $@
>
>   lib_LTLIBRARIES		= libcldc.la
>
> -libcldc_la_SOURCES	= cldc.c cldc-udp.c cldc-dns.c common.c
> +libcldc_la_SOURCES	= cldc.c cldc-udp.c cldc-dns.c common.c libtimer.c
>
>   libcldc_la_LDFLAGS = \
>   	-version-info $(LIBCLDC_CURRENT):$(LIBCLDC_REVISION):$(LIBCLDC_AGE) \
>   	-no-undefined \
>   	-export-symbols-regex "^[^_].*"
>
> -noinst_LIBRARIES	= libtimer.a
> +noinst_LIBRARIES	=
>
>   pkgconfigdir = $(libdir)/pkgconfig
>   pkgconfig_DATA = libcldc.pc


applied 1-2, and fixed some bugs:

* removed now-empty noinst_LIBRARIES

* libtimer.c functions were exported into the lib, but no header was 
made available, meaning they could not really be used outside CLD tree. 
  Folded libtimer.h into cld_common.h, which is installed on end-user 
systems.