From: Haicheng Li <haicheng.li@linux.intel.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: David Rientjes <rientjes@google.com>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
x86@kernel.org, Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org
Subject: Re: [patch] x86: set hotpluggable nodes in nodes_possible_map
Date: Thu, 21 Jan 2010 11:00:00 +0800 [thread overview]
Message-ID: <4B57C330.7020505@linux.intel.com> (raw)
In-Reply-To: <4B578797.3040908@kernel.org>
Yinghai Lu wrote:
>
> if (ma->flags & ACPI_SRAT_MEM_HOT_PLUGGABLE) {
> update_nodes_add(node, start, end);
> /* restore nodes[node] */
> *nd = oldnode;
> if ((nd->start | nd->end) == 0)
> node_clear(node, nodes_parsed);
> }
>
> removing clearing with nodes_parsed is not working?
>
> YH
Yinghai,
Theoretically removing clearing with nodes_parsed can work fine except that it requires more
consideration, since some functions already based on nodes_parsed, like acpi_get_nodes(), is
supposing nodes_parsed just represents for nodes with memory on.
See my another email to David, I think we'd better keep hotpluggable node info separately since it
is straightforward as well as would be useful for future hotplug related usage. How do you think
about it? thanks.
-haicheng
next prev parent reply other threads:[~2010-01-21 3:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 7:42 [PATCH] x86/mm/srat_64.c: nodes_parsed should include all nodes detected by ACPI Haicheng Li
2010-01-17 2:22 ` Haicheng Li
2010-01-17 21:53 ` David Rientjes
2010-01-18 6:30 ` Yinghai Lu
2010-01-18 10:43 ` David Rientjes
2010-01-19 11:08 ` Haicheng Li
2010-01-19 11:29 ` Haicheng Li
2010-01-19 23:30 ` David Rientjes
2010-01-20 16:40 ` Haicheng Li
2010-01-20 20:10 ` [patch] x86: set hotpluggable nodes in nodes_possible_map David Rientjes
2010-01-20 22:45 ` Yinghai Lu
2010-01-20 23:32 ` David Rientjes
2010-01-21 3:00 ` Haicheng Li [this message]
2010-01-21 2:58 ` Haicheng Li
2010-01-21 6:58 ` David Rientjes
2010-01-21 7:31 ` Haicheng Li
2010-01-21 7:50 ` David Rientjes
2010-01-21 8:33 ` Haicheng Li
2010-01-21 23:12 ` David Rientjes
2010-01-22 4:06 ` [PATCH] x86/mm/srat_64.c: make node_possible_map include hotpluggable node Haicheng Li
2010-01-22 7:33 ` H. Peter Anvin
2010-01-22 8:43 ` Haicheng Li
2010-01-22 10:14 ` H. Peter Anvin
2010-01-22 10:35 ` Haicheng Li
2010-01-22 11:15 ` [tip:x86/urgent] x86: Set hotpluggable nodes in nodes_possible_map tip-bot for David Rientjes
2010-01-23 6:51 ` tip-bot for David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B57C330.7020505@linux.intel.com \
--to=haicheng.li@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.