From: Eric Dumazet <eric.dumazet@gmail.com>
To: Changli Gao <xiaosuo@gmail.com>
Cc: Tom Herbert <therbert@google.com>,
davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH v5] rps: Receive Packet Steering
Date: Thu, 21 Jan 2010 10:16:21 +0100 [thread overview]
Message-ID: <4B581B65.7070109@gmail.com> (raw)
In-Reply-To: <412e6f7f1001202354g1022bb64rae267a1b19713b8a@mail.gmail.com>
Le 21/01/2010 08:54, Changli Gao a écrit :
> Sometimes, rxhash will be 0 generated. In order to check whether
> rxhash is generated or not, a new bit field in sk_buff is needed. When
> rxhash is generated and saved in sk_buff, the bit is set.
>
> And, I think rxhash should be reserved when calling skb_copy and skb_clone.
>
>
I disagree
A null rxhash should not be generated by a driver, or even if its null,
why should we care ?
In this very unlikely event, let get_rps_cpu() compute a (non null) hash.
Adding a bit in skb for such low probability event brings nothing but complexity.
next prev parent reply other threads:[~2010-01-21 9:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 21:56 [PATCH v5] rps: Receive Packet Steering Tom Herbert
2010-01-14 22:56 ` Stephen Hemminger
2010-01-14 23:31 ` Rick Jones
2010-01-16 2:11 ` Ben Hutchings
2010-01-17 17:22 ` Stephen Hemminger
2010-01-15 2:22 ` Changli Gao
2010-01-15 6:19 ` Eric Dumazet
2010-01-15 6:39 ` Changli Gao
2010-01-15 6:57 ` Eric Dumazet
2010-01-15 8:49 ` David Miller
2010-01-15 9:20 ` Changli Gao
2010-01-15 9:26 ` David Miller
2010-01-21 7:04 ` Changli Gao
2010-01-15 9:45 ` David Miller
2010-01-15 8:50 ` David Miller
2010-01-15 9:05 ` Changli Gao
2010-01-15 6:27 ` Eric Dumazet
2010-01-16 2:26 ` Ben Hutchings
2010-01-21 7:54 ` Changli Gao
2010-01-21 9:16 ` Eric Dumazet [this message]
2010-01-28 6:04 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B581B65.7070109@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
--cc=xiaosuo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.