Re: Getting patches committed

[Philip Balister <philip@balister.org>]

On 01/21/2010 07:36 AM, Thomas Zimmermann wrote:
> Am Donnerstag 21 Januar 2010 13:15:21 schrieb Philip Balister:
>> On 01/21/2010 05:20 AM, Dr. Michael Lauer wrote:
>>> Am 21.01.2010 um 11:02 schrieb Holger Hans Peter Freyther:
>>>>> 2. Is there a way to have a staging branch where all patches are
>>>>> committed to, which have not been reviewed for let us say one week, to
>>>>> get more testing and before they go into the dev branch? Maybe it is
>>>>> easier for people to at least test build such a branch?
>>>>
>>>> Would you be interested in creating such a branch for us? I assume it is
>>>> certainly easier to git cherry-pick a patch than to download the mbox
>>>> and use git am..
>>>
>>> I fully agree. I'm neither using patchwork nor do I find patches on the
>>> list a good idea. I'd welcome for-oe-upstream trees that would contain
>>> patches that -- if good -- we could just pull from.
>>
>> I actually like patches on the list, because it makes me aware of how is
>> doing work and keeps me aware of the kinds of things people without
>> commit access are interested in. Also, it gives people with commit
>> access a forum for changes they would like reviewed.
>>
>> I am not opposed to someone creating a git branch or branches created
>> from list patches, but do not want to see the patches disappear from the
>> list.
>>
>> If the patch that was sent to the list comes from git-send-patch (I hope
>> I hve that correct) there is a script contrib/patchwork/git-am.sh that
>> makes it really easy to apply the patch.
>>
>> Philip
>
> I'm one of those without commit rights :)
> And i think the problem is, that nobody feels responsible for the patches on
> patchwork. I know this situation from SHR patchwork, when you don't ask
> someone directly to commit a patch from patchwork, nobody will do it.
> That's the only way it really works currently.
> I have 4 people with commit rights i can ask, so i have no problems but others
> probably doesn't know someone...
>
> I think a sort of moderator for patchwork is needed, that assosiats patches to
> the maintainer.

There is nothing wrong with nagging people on the list and on irc to 
commit your patch :) Sometimes I will commit stuff just because the 
author takes a little time to explain the patch to me.

Philip