From: Semih Hazar <semih.hazar@indefia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add support for Indefia Nimbus Cloud Board
Date: Thu, 21 Jan 2010 15:13:35 +0200 [thread overview]
Message-ID: <4B5852FF.5080709@indefia.com> (raw)
In-Reply-To: <20100117231747.765FCC88AE@gemini.denx.de>
Dear Wolfgang,
Please find my answers below.
>
> Is ther e a chance to do without this file and use the CFI driver
> instead?
>
>
There's currently a problem with the CFI driver in AVR32 platform. There
was a long discussion about it, but a solution was not available. If
that issue is solved, I can submit a patch to change this to use CFI.
>
>> + // First 8 sectors are 8k
>>
> Please do not use C++ comments.
>
>
These are fixed.
>
>> + /* Enable GPIO on config swicthes */
>> + portmux_select_gpio(PORTMUX_PORT_B, (1 << 13) | (1 << 14) | (1 << 15) | (1 << 16),
>>
> Line too long. Please fix globally.
>
>
Fixed.
> Line too long. And please use strmhz() to print clock frequencies.
>
> Um... this print does not belong here at all. CPU init messages and
> board initi messages have no place in initdram() at all.
>
>
Removed it.
>> diff --git a/board/indefia/nimbuscloud/u-boot.lds b/board/indefia/nimbuscloud/u-boot.lds
>> new file mode 100644
>> index 0000000..a7243f2
>> --- /dev/null
>> +++ b/board/indefia/nimbuscloud/u-boot.lds
>>
> Do you really need a board specific linker script?
>
>
>
The README file says to put a u-boot.lds file for a new board and I did
so. I also looked at the other AVR32 boards and they all also have it.
If there's another way, I can change it.
I'm sending the revised patch in another mail.
Best regards,
Semih Hazar
next prev parent reply other threads:[~2010-01-21 13:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-17 13:12 [U-Boot] [PATCH] Add support for Indefia Nimbus Cloud Board Semih Hazar
2010-01-06 9:18 ` Semih Hazar
2010-01-17 23:17 ` Wolfgang Denk
2010-01-21 13:13 ` Semih Hazar [this message]
2010-01-25 22:31 ` Wolfgang Denk
2010-02-04 17:13 ` Semih Hazar
2010-03-01 14:12 ` Semih Hazar
2010-03-21 16:35 ` Wolfgang Denk
2010-03-21 16:34 ` Wolfgang Denk
2010-03-22 9:23 ` Stefan Roese
2010-03-23 17:41 ` Semih Hazar
2010-03-23 20:01 ` Wolfgang Denk
2010-03-24 14:51 ` Stefan Roese
2010-02-04 17:14 ` Semih Hazar
2010-03-21 16:44 ` Wolfgang Denk
2010-01-21 13:13 ` Semih Hazar
2010-01-25 22:34 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5852FF.5080709@indefia.com \
--to=semih.hazar@indefia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.