Re: [PATCH 4/6] SPI: S3C64XX: Check before mem-region release

[Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>]

On 21.01.2010 16:00, Grant Likely wrote:
> On Wed, Jan 20, 2010 at 8:06 PM, jassi brar <jassisinghbrar@gmail.com> wrote:
>   
>> On Thu, Jan 21, 2010 at 11:55 AM, Grant Likely
>> <grant.likely@secretlab.ca> wrote:
>>     
>>> On Wed, Jan 20, 2010 at 6:46 PM, jassi brar <jassisinghbrar@gmail.com> wrote:
>>>       
>>>> On Thu, Jan 21, 2010 at 10:35 AM, jassi brar <jassisinghbrar@gmail.com> wrote:
>>>>         
>>>>> Hi Grant Likely,
>>>>>  You have reviewed this series of patches but didn't ACK/NAK.
>>>>> Could you kindly confirm if u accept them or want some changes?
>>>>> Thanks.
>>>>>           
>>>> Nevermind, I just saw ur ACK at my official ID (many maintainers reply
>>>> something like
>>>> 'pulled now' to the patch thread but thats ok if you ACK personally).
>>>> Thanks.
>>>>         
>>> I'm using patchwork.kernel.org for collecting spi patches.
>>> Unfortunately patchwork doesn't provide any mechanism for emailing
>>> "merged" messages when I accept patches.  To compensate, I've started
>>> cc'ing patch authors my next- branch update message when I push out an
>>> updated tree.
>>>
>>> You can also always look at patchwork.kernel.org to see if your
>>> patches are still in the queue.  I won't forget accidentally drop any
>>> patches tracked by patchwork.
>>>       
>> well, it might not just be the submitter, but also others in the thread
>> interested in knowing the fate of a particular patch. And having to
>> poll some repo for that, isn't very efficient. It's not important to be notified
>> _when_ you accept the patch, but only _if_ you accept, which I think
>> you would know after seeing the patch and/or some further clarifications
>> from the submitter.
>>     
>
> Since I review patches on patchwork, I don't have an easy link between
> what I'm picking up and my email client.  Only when I need to comment
> on something will I actually go and find the thread in my mailer.  So
> it is considerably less efficient for me to go and reply to every
> patch submission.
>
> Jeremy, would it be possible to have a way of sending out a status
> update email from within patchwork?
>   

There is an unfinished Patchwork patch which allows you to click on a
mailto: link at the beginning of the Patchwork page and your mailer will
preserve threading (sort of, the reply will always be to the original
patch, and the list and the submitter will be in CC). Basically, the
mailto: link has In-Reply-To and Subject headers set to correct values.
It might be possible to extend this a bit and get all responders added
to CC.

That patch is unfinished, though, so if you know Python, Patchwork, and
the framework used by Patchwork you can probably beat it into a shape
that is useful for your purposes. If you're interested, I can dig it up.

Regards,
Carl-Daniel

-- 
Developer quote of the year:
"We are juggling too many chainsaws and flaming arrows and tigers."