From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ky Srinivasan" Subject: Re: [PATCH] PV driver compatibility Date: Thu, 21 Jan 2010 16:04:41 -0700 Message-ID: <4B587B19020000300007DE08@sinclair.provo.novell.com> References: <4B586E2D020000300007DDE1@sinclair.provo.novell.com> <4B587B19020000300007DE08@sinclair.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian.Campbell@citrix.com, Keir.Fraser@eu.citrix.com Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org >>> On 1/21/2010 at 3:38 PM, in message < 1264106300.21707.57.camel@localhost.localdomain >, Ian Campbell < Ian.Campbell@citrix.com > wrote:=20 > On Wed, 2010-01-20 at 16:07 +0000, Keir Fraser wrote:=20 >> On 20/01/2010 16:02, "Ky Srinivasan" < ksrinivasan@novell.com > = wrote: >>=20 >> > The attached patch fixes what I believe is a typo and permits = guests=20 > running >> > the latest PV drivers to correctly interact with older back-ends. >> >=20 >> > Signed-off-by: K. Y. Srinivasan < ksrinivasan@novell.com > >>=20 >> Ian, >>=20 >> You introduced the magic port value check, in xen-unstable:19964. >=20 > I'm guilty of pretty poor changelogging there, aren't I, I've no idea > how the unmodified drivers part of the change relates to the comment :-( >=20 >> Can you ack/nack this please? >=20 > What vintage of older back-ends are we talking about? We shipped sles11 on xen-3.3.1 and this is where we encountered the = problem - hosting a sles11 sp1 (based on xen-4.0.0) guest on a sles11 = host.=20 >=20 > What is their behaviour when reading from that port? Can we test for a > specific value instead of anything !=3D MAGIC or is there some other way > to identify them?=20 Looking at your documentation for this new protocol, I recall seeing that = if the magic value was not read, it was ok to silently return to be = compatible. >=20 > Without some sort of unplugging mechanism we run the risk of having both > PV and Emulated disk controllers active, accessing the same virtual disk > and with drivers loaded in the guest, which is potentially very > dangerous for the user's data. Did those older backends implement some > alternative unplugging mechanism we should be trying? We have had a mechanism for disabling the emulation when the PV drivers = are loaded for some time now. >=20 > The whole point of this magic check is to ensure we are running on a > backend which is new enough to do the unplugging in a safe way, so I > think failing to switch to PV and sticking with emulated on such > platforms the safe approach. This breaks the compatibility with systems that have already been shipped = in the sense we cannot run the guests with PV drivers. The proposed patch = fixes the problem. Regards, K. Y >=20 > I'd suggest that this issue should be fixed by backporting the backend > support for the safe unplug protocol -- I don't think the patch for such > minimal support is that big or risky. Failing that perhaps it could at > least be something you need to explicitly ask for if you have somehow > verified that there is no danger of the emulated and PV backends > trampling each other, e.g. via a frontend module parameter. >=20 > Ian.