From: Gerd Hoffmann <kraxel@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/3] qdev: Add help for device properties
Date: Thu, 21 Jan 2010 18:28:21 +0100 [thread overview]
Message-ID: <4B588EB5.9000507@redhat.com> (raw)
In-Reply-To: <m37hrbs905.fsf@blackfin.pond.sub.org>
On 01/21/10 17:44, Markus Armbruster wrote:
> Markus Armbruster<armbru@redhat.com> writes:
>
>>> - fprintf(stderr, "property \"%s.%s\" not found\n",
>>> - dev->info->name, name);
>>> + fprintf(stderr, "%s.%s\n", dev->info->name, props->name);
>>> + props++;
> One question, though: why print DRIVER.PROPNAME instead of just
> PROPNAME? You could still put DRIVER into the heading, say "Properties
> of DRIVER:".
Probably for consistency with the error messages.
cheers,
Gerd
next prev parent reply other threads:[~2010-01-21 17:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-16 17:19 [Qemu-devel] [PATCH] Documentation: Add missing documentation for qdev related command line options Stefan Weil
2010-01-18 10:09 ` Markus Armbruster
2010-01-18 19:32 ` Stefan Weil
2010-01-19 9:38 ` Markus Armbruster
2010-01-20 22:05 ` Stefan Weil
2010-01-21 16:45 ` Markus Armbruster
2010-01-19 13:32 ` [Qemu-devel] " Michael S. Tsirkin
2010-01-20 21:58 ` [Qemu-devel] [PATCH 1/3] qdev: Add help for device properties Stefan Weil
2010-01-20 21:58 ` [Qemu-devel] [PATCH 2/3] qdev: Add help for property value Stefan Weil
2010-01-20 21:58 ` [Qemu-devel] [PATCH 3/3] Documentation: Improve command line help for -device option Stefan Weil
2010-01-21 16:42 ` [Qemu-devel] [PATCH 2/3] qdev: Add help for property value Markus Armbruster
2010-01-21 16:38 ` [Qemu-devel] [PATCH 1/3] qdev: Add help for device properties Markus Armbruster
2010-01-21 16:44 ` Markus Armbruster
2010-01-21 17:28 ` Gerd Hoffmann [this message]
2010-01-20 14:55 ` [Qemu-devel] [PATCH] Documentation: Add missing documentation for qdev related command line options Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B588EB5.9000507@redhat.com \
--to=kraxel@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.