From: thommycheck@gmx.de (Thomas Kunze)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] [ARM] sa1100: remove unreferenced IRQ definitions
Date: Thu, 21 Jan 2010 19:01:31 +0100 [thread overview]
Message-ID: <4B58967B.30406@gmx.de> (raw)
In-Reply-To: <201001101804.06642.marek.vasut@gmail.com>
Marek Vasut schrieb:
> Dne ?t 31. prosince 2009 14:23:56 Thomas Kunze napsal(a):
>
>> Eric Miao wrote:
>>
>>> These IRQ definitions related to LOCOMO are never referenced anywhere,
>>> thus could be safely removed.
>>>
>>> Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
>>> ---
>>> arch/arm/mach-sa1100/include/mach/collie.h | 7 -------
>>> 1 files changed, 0 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-sa1100/include/mach/collie.h
>>> b/arch/arm/mach-sa1100/include/mach/collie.h index 71a0b3f..52acda7
>>> 100644
>>> --- a/arch/arm/mach-sa1100/include/mach/collie.h
>>> +++ b/arch/arm/mach-sa1100/include/mach/collie.h
>>> @@ -72,13 +72,6 @@
>>> #define COLLIE_IRQ_GPIO_GA_INT IRQ_GPIO25
>>> #define COLLIE_IRQ_GPIO_MAIN_BAT_LOW IRQ_GPIO26
>>>
>>> -#define COLLIE_LCM_IRQ_GPIO_RTS IRQ_LOCOMO_GPIO0
>>> -#define COLLIE_LCM_IRQ_GPIO_CTS IRQ_LOCOMO_GPIO1
>>> -#define COLLIE_LCM_IRQ_GPIO_DSR IRQ_LOCOMO_GPIO2
>>> -#define COLLIE_LCM_IRQ_GPIO_DTR IRQ_LOCOMO_GPIO3
>>> -#define COLLIE_LCM_IRQ_GPIO_nSD_DETECT IRQ_LOCOMO_GPIO13
>>> -#define COLLIE_LCM_IRQ_GPIO_nSD_WP IRQ_LOCOMO_GPIO14
>>> -
>>> /* GPIO's on the TC35143AF (Toshiba Analog Frontend) */
>>> #define COLLIE_TC35143_GPIO_BASE (GPIO_MAX + 13)
>>> #define COLLIE_TC35143_GPIO_VERSION0 UCB_IO_0
>>>
>> Those definitions are used in out-of-tree drivers. So please don't
>> remove them.
>>
>
> Why aren't those in-the-tree already?
>
Because I always seem to miss the right time to submit pull requests.
>> Regards,
>> Thomas
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
>>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
next prev parent reply other threads:[~2010-01-21 18:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-28 5:18 [PATCH 0/7] pxa/sa1100: irqs.h cleanup Eric Miao
2009-12-28 5:18 ` [PATCH 1/7] [ARM] sa1100: remove unreferenced IRQ definitions Eric Miao
2009-12-31 13:23 ` Thomas Kunze
2010-01-10 17:04 ` Marek Vasut
2010-01-21 18:01 ` Thomas Kunze [this message]
2009-12-28 5:18 ` [PATCH 2/7] [ARM] locomo: avoid the unnecessary cascade of keyboard IRQ Eric Miao
2009-12-31 13:47 ` Thomas Kunze
2010-01-01 3:35 ` Eric Miao
2010-01-02 11:43 ` Russell King - ARM Linux
2010-01-03 8:07 ` Eric Miao
2009-12-28 5:18 ` [PATCH 3/7] [ARM] locomo: remove unused IRQs and avoid unnecessary cascade Eric Miao
2009-12-31 13:42 ` Thomas Kunze
2010-01-01 2:59 ` Eric Miao
2010-01-10 14:31 ` Thomas Kunze
2010-01-02 11:45 ` Russell King - ARM Linux
2009-12-28 5:18 ` [PATCH 4/7] [ARM] locomo: allow cascaded IRQ base to be specified by platforms Eric Miao
2009-12-28 21:14 ` Pavel Machek
2009-12-29 1:07 ` Eric Miao
2009-12-28 5:18 ` [PATCH 5/7] [ARM] sa1111: avoid using hardcoded IRQ numbers for PCMCIA driver Eric Miao
2009-12-28 5:18 ` [PATCH 6/7] [ARM] sa1111: allow cascaded IRQs to be used by platforms Eric Miao
2009-12-28 5:18 ` [PATCH 7/7] [ARM] pxa: move board board IRQ definitions out of irqs.h Eric Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B58967B.30406@gmx.de \
--to=thommycheck@gmx.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.