From: Pal-Kristian Engstad <pal_engstad@naughtydog.com>
To: Nicolas Pitre <nico@fluxnic.net>
Cc: Simon Hausmann <simon@lst.de>, Junio C Hamano <gitster@pobox.com>,
"git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: [PATCH 3/3] git-p4: improve submit performance on new P4 servers
Date: Thu, 21 Jan 2010 18:58:29 -0800 [thread overview]
Message-ID: <4B591455.7050409@naughtydog.com> (raw)
In-Reply-To: <alpine.LFD.2.00.1001212147480.1726@xanadu.home>
Nicolas Pitre wrote:
> On Thu, 21 Jan 2010, Pal-Kristian Engstad wrote:
>
>> Improve git-p4 submit performance on newer (from 2009.2) Perforce
>> servers by changing "p4 diff -du" to "p4 diff -dub". This change is
>> harmless since the output is only used for display purposes.
>>
>> Signed-off-by: Pal-Kristian Engstad <pal_engstad@naughtydog.com>
>
> Why is the b flag impacting performance?
That's a very good question. The release notes say that they've been
changing how 'p4 diff -du' works, but the net effect of it all is that
it stats all files in the whole working set. For large projects, this
takes forever. We say pauses of 3 minutes per submit...
> And even if for display purposes, why might you wish not to see
> differences in whitespace changes?
That's a good point, but what alternative is there?
PKE
--
Pål-Kristian Engstad (engstad@naughtydog.com),
Lead Graphics & Engine Programmer,
Naughty Dog, Inc., 1601 Cloverfield Blvd, 6000 North,
Santa Monica, CA 90404, USA. Ph.: (310) 633-9112.
"Emacs would be a far better OS if it was shipped with
a halfway-decent text editor." -- Slashdot, Dec 13. 2005.
next prev parent reply other threads:[~2010-01-22 2:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 2:06 [PATCH 3/3] git-p4: improve submit performance on new P4 servers Pal-Kristian Engstad
2010-01-22 2:49 ` Nicolas Pitre
2010-01-22 2:58 ` Pal-Kristian Engstad [this message]
2010-01-22 3:59 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B591455.7050409@naughtydog.com \
--to=pal_engstad@naughtydog.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@fluxnic.net \
--cc=simon@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.