From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NYNrG-0006S7-Sk for mharc-grub-devel@gnu.org; Fri, 22 Jan 2010 13:03:46 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NYNrF-0006Ro-2W for grub-devel@gnu.org; Fri, 22 Jan 2010 13:03:45 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NYNr9-0006RD-8B for grub-devel@gnu.org; Fri, 22 Jan 2010 13:03:43 -0500 Received: from [199.232.76.173] (port=54377 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NYNr8-0006R9-TQ for grub-devel@gnu.org; Fri, 22 Jan 2010 13:03:38 -0500 Received: from mail-bw0-f215.google.com ([209.85.218.215]:61025) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NYNr8-0002SQ-8D for grub-devel@gnu.org; Fri, 22 Jan 2010 13:03:38 -0500 Received: by bwz7 with SMTP id 7so1313069bwz.26 for ; Fri, 22 Jan 2010 10:03:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=spHZdOSnXART2SGHx+3JFgMR6o5KbKnX73Gsuk55ADc=; b=ZK5dJUNYOMLwAaxYnuOvEsXJp0Mf+f3xIV1T/bMpXlfhycljcj4dg8DnnPjg40g2pw WUQ+ki4kR79T7ASWDNEKA+gVNmsFMc5976pDvjRFJTeQsU3+fzChiyA6PRP15trLH7jn pDS+MxKcSXNj2O0iuUHswJbiRO/l3bt/+WlXU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=uL0nbicEGaoxkNdjd5WNRpxy/w0bXh7R7/dtPJRaAKWpCHXiSqW51GMXBg4F0bGdqW LbbgvVtVtqHjd+Rud7Q3s2Z9saz832QI7/U4ItyvuQett6zuIdmjKIjv+f0Tfz1FWDdl O9KdKA3GESp7x1Qlfln4s6oJGARDDBEkFeFTc= Received: by 10.204.8.5 with SMTP id f5mr1165060bkf.59.1264183417198; Fri, 22 Jan 2010 10:03:37 -0800 (PST) Received: from debian.bg45.phnet (gprs35.swisscom-mobile.ch [193.247.250.35]) by mx.google.com with ESMTPS id 14sm1097265bwz.9.2010.01.22.10.03.34 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 22 Jan 2010 10:03:35 -0800 (PST) Message-ID: <4B59E869.700@gmail.com> Date: Fri, 22 Jan 2010 19:03:21 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <20090802222505.GI15139@thorin> <20090804201512.GA15811@thorin> <20090817140657.GP32551@thorin> <20100122165300.GA14428@thorin> In-Reply-To: <20100122165300.GA14428@thorin> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigDD4B6B8837E1735057C79ABE" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: [PATCH] nested partitions X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jan 2010 18:03:45 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDD4B6B8837E1735057C79ABE Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Robert Millan wrote: > I haven't checked the specific details, but I think this approach is fi= ne IF > we only recurse for partition types where this makes sense. This inclu= des: > > - BSD partition types inside MSDOS labels > - Solaris partition type inside MSDOS labels > =20 What with minix? > This can be done by extending "has_partitions" to be set to "yes" in th= ose > specific partition types. The implementation should be the least intru= sive > possible, taking into account that this kind of situations are an oddit= y > rather than the norm. > > =20 Partition types are easily screwed. Why not just check for the presence of the label? > As for the other situations, the more I think about this, the more conv= inced > I am that this whole "partition nesting" concept is a broken mess. I t= hink I > already explained why in this list, but I can rehash the reasons if any= one's > interested. I don't want to compromise on such part of GRUB core for t= he sake > of supporting this kind of layouts. > =20 Actually I don't see my patch as of any compromise. On the contrary: current code is a compromise with a horrible set of functions verbatimly replicated across all partition modules. > The only reason I'm open to implementing these two cases [1] is that th= ey seem > to be inmensely popular among *BSD systems and Solaris derivatives. > > =20 Solaris nested partition table provides decent embedding region. FreeBSD supports GPT and doesn't attempt to nest partitions on it. > As for *BSD and Solaris who read this, my advice is to step away, ditch= the > whole MSDOS label burden and just settle on a clean label without the l= imits > DOS ones have. If you strive for compatibility, GPT is a good choice I= MO (and > the rest of the free world seems to be moving in this direction thanks = to 2 TiB > limit). > > [1] I know the first one is already implemented, but your approach make= s it > less ad-hoc and splits code off part_msdos.mod, which is an improve= ment. > > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigDD4B6B8837E1735057C79ABE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAktZ6HEACgkQNak7dOguQgmKMAD/c8vLWXooYxujpKCJxmFZt/vj FYHYc16jX1slUzLzzT0BAKWxy98ZDE7xyDWjhwP/BlV/X5BfrBZH24LUNL06Mw8m =XNB1 -----END PGP SIGNATURE----- --------------enigDD4B6B8837E1735057C79ABE--