From: Sunil Mushran <sunil.mushran@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH] ocfs2: fix a misleading variable name
Date: Fri, 22 Jan 2010 13:51:13 -0800 [thread overview]
Message-ID: <4B5A1DD1.1010703@oracle.com> (raw)
In-Reply-To: <201001221359.o0MDwHkW015414@acsinet15.oracle.com>
Ack
Wengang Wang wrote:
> a local variable "dlm_version" is used as a fs locking version.
> rename it fs_version.
>
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
> ---
> fs/ocfs2/stack_o2cb.c | 12 ++++++------
> 1 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ocfs2/stack_o2cb.c b/fs/ocfs2/stack_o2cb.c
> index e49c410..3038c92 100644
> --- a/fs/ocfs2/stack_o2cb.c
> +++ b/fs/ocfs2/stack_o2cb.c
> @@ -277,7 +277,7 @@ static int o2cb_cluster_connect(struct ocfs2_cluster_connection *conn)
> u32 dlm_key;
> struct dlm_ctxt *dlm;
> struct o2dlm_private *priv;
> - struct dlm_protocol_version dlm_version;
> + struct dlm_protocol_version fs_version;
>
> BUG_ON(conn == NULL);
> BUG_ON(o2cb_stack.sp_proto == NULL);
> @@ -304,18 +304,18 @@ static int o2cb_cluster_connect(struct ocfs2_cluster_connection *conn)
> /* used by the dlm code to make message headers unique, each
> * node in this domain must agree on this. */
> dlm_key = crc32_le(0, conn->cc_name, conn->cc_namelen);
> - dlm_version.pv_major = conn->cc_version.pv_major;
> - dlm_version.pv_minor = conn->cc_version.pv_minor;
> + fs_version.pv_major = conn->cc_version.pv_major;
> + fs_version.pv_minor = conn->cc_version.pv_minor;
>
> - dlm = dlm_register_domain(conn->cc_name, dlm_key, &dlm_version);
> + dlm = dlm_register_domain(conn->cc_name, dlm_key, &fs_version);
> if (IS_ERR(dlm)) {
> rc = PTR_ERR(dlm);
> mlog_errno(rc);
> goto out_free;
> }
>
> - conn->cc_version.pv_major = dlm_version.pv_major;
> - conn->cc_version.pv_minor = dlm_version.pv_minor;
> + conn->cc_version.pv_major = fs_version.pv_major;
> + conn->cc_version.pv_minor = fs_version.pv_minor;
> conn->cc_lockspace = dlm;
>
> dlm_register_eviction_cb(dlm, &priv->op_eviction_cb);
>
next prev parent reply other threads:[~2010-01-22 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 13:58 [Ocfs2-devel] [PATCH] ocfs2: fix a misleading variable name Wengang Wang
2010-01-22 21:51 ` Sunil Mushran [this message]
2010-01-26 3:52 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5A1DD1.1010703@oracle.com \
--to=sunil.mushran@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.