From: Magnus Lilja <lilja.magnus@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] SPI: Fix 32 bit transfers in mxc_spi.c
Date: Sat, 23 Jan 2010 18:08:28 +0100 [thread overview]
Message-ID: <4B5B2D0C.1030907@gmail.com> (raw)
In-Reply-To: <20100117230233.23CFDC88AE@gemini.denx.de>
Dear Feng and Tom,
Is this in a queue somewhere to be merged? If not, could you please apply this and make a pull request for it?
Bset regards, Magnus Lilja
Wolfgang Denk skrev:
> Dear Feng,
>
> can you please take care of this?
>
> In message <1263726375-4929-1-git-send-email-lilja.magnus@gmail.com> Magnus Lilja wrote:
>> Commit f9b6a1575d9f1ca192e4cb60e547aa66f08baa3f, "i.MX31: fix SPI
>> driver for shorter than 32 bit" broke 32 bit transfers. This patch
>> makes single 32 bit transfer work again.
>>
>> Transfer lengths that are known not to work will abort and print
>> an error message.
>>
>> Tested on i.MX31 Litekit and i.MX31 PDK using 32 bit transfers to
>> the MC13783/ATLAS chip (using the 'date' command).
>>
>> Signed-off-by: Magnus Lilja <lilja.magnus@gmail.com>
>> ---
>>
>> As discussed on the mailing list, Guennadi Liakhovetski thinks that
>> all transfers > 16 bits are broken. This patch fixes the 32 bit case
>> and makes sure the user is notified if a broken bitlength is used.
>>
>> drivers/spi/mxc_spi.c | 9 +++++++++
>> 1 files changed, 9 insertions(+), 0 deletions(-)
>
> Acked-by: Wolfgang Denk <wd@denx.de>
>
> Best regards,
>
> Wolfgang Denk
>
next prev parent reply other threads:[~2010-01-23 17:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 11:06 [U-Boot] [PATCH v2] SPI: Fix 32 bit transfers in mxc_spi.c Magnus Lilja
2010-01-17 23:02 ` Wolfgang Denk
2010-01-23 17:08 ` Magnus Lilja [this message]
2010-02-07 18:43 ` Tom
2010-02-08 20:06 ` Magnus Lilja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5B2D0C.1030907@gmail.com \
--to=lilja.magnus@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.