From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
qemu-devel@nongnu.org, Adam Litke <agl@us.ibm.com>
Subject: Re: [Qemu-devel] [RFC] New API for asynchronous monitor commands
Date: Sun, 24 Jan 2010 16:19:14 +0200 [thread overview]
Message-ID: <4B5C56E2.3050602@redhat.com> (raw)
In-Reply-To: <4B5C52B8.6050900@codemonkey.ws>
On 01/24/2010 04:01 PM, Anthony Liguori wrote:
>> Instead of sending opaques everywhere (and having them correspond to
>> different types in different cases), I would prefer it if the handle
>> always accepted an AsyncCommandCompletion *. That makes it easier to
>> follow the code, since there are no opaques you have to guess the
>> true type of.
>
>
> I agree with you in principle but the model of passing (function
> pointer, opaque) is pervasive within QEMU. I'd prefer consistency
> here and if we want to switch to something more like a function
> object, we do it globally.
At least some recent code has moved in this direction (together with
container_of()), but I don't think there's a reason to press this issue now.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-01-24 14:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-22 19:03 [Qemu-devel] [RFC] New API for asynchronous monitor commands Adam Litke
2010-01-22 23:17 ` [Qemu-devel] " Anthony Liguori
2010-01-24 10:55 ` Avi Kivity
2010-01-25 13:10 ` Luiz Capitulino
2010-01-24 10:59 ` [Qemu-devel] " Avi Kivity
2010-01-24 14:01 ` Anthony Liguori
2010-01-24 14:19 ` Avi Kivity [this message]
2010-01-25 13:12 ` Luiz Capitulino
2010-01-25 13:08 ` [Qemu-devel] " Luiz Capitulino
2010-01-25 14:00 ` Adam Litke
2010-01-25 15:02 ` Luiz Capitulino
2010-01-25 14:15 ` Anthony Liguori
2010-01-25 14:51 ` Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5C56E2.3050602@redhat.com \
--to=avi@redhat.com \
--cc=agl@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.