All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: autofs@linux.kernel.org
Subject: Re: [PATCH 1/7] autofs4: Save autofs trigger's vfsmount in super block info
Date: Mon, 25 Jan 2010 00:16:10 -0800	[thread overview]
Message-ID: <4B5D534A.4040202@zytor.com> (raw)
In-Reply-To: <1263843353.4127.33.camel@localhost>

On 01/18/2010 11:35 AM, Trond Myklebust wrote:
> On Mon, 2010-01-18 at 10:27 +0000, Al Viro wrote:
>> Back to another question: which syscalls should and which syscalls should not
>> trigger automount on the last component?  Note that it's something we'd better
>> be consistent about between autofs4 and cifs/afs/nfs...
>
> In addition to the ones that trigger automounts now:
>
> One syscall that we've had a lot of complaints about is 'stat()'. Since
> it doesn't follow symlinks, it will fail to trigger the automount, and
> will return bogus values for st_dev. This again confuses some versions
> of the 'du' utility that check the value of st_dev before and after
> entering the subdir.
> (see https://bugzilla.redhat.com/show_bug.cgi?id=431166 )
>

[Sorry for late comment]

I presume you mean lstat() here.  This is *exactly* the intended 
semantics -- this prevents a GUI from looking in /home with enumeration 
enabled, and mounting *every single subvolume* in that map.

Thus the semantic: "don't automount if you wouldn't follow a symlink". 
It's perhaps not *ideal*, but it is a pretty decent approximation, easy 
to describe, and serves the purpose.

	-hpa

  reply	other threads:[~2010-01-25  8:16 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-23 23:36 [PATCH 0/7] VFS prep for union mounts/writable overlays Valerie Aurora
2009-12-23 23:36 ` [PATCH 1/7] autofs4: Save autofs trigger's vfsmount in super block info Valerie Aurora
2009-12-23 23:36   ` [PATCH 2/7] VFS: Make lookup_hash() return a struct path Valerie Aurora
2009-12-23 23:36     ` [PATCH 3/7] VFS: Make real_lookup() " Valerie Aurora
2009-12-23 23:37       ` [PATCH 4/7] VFS: Propagate mnt_flags into do_loopback Valerie Aurora
2009-12-23 23:37         ` [PATCH 5/7] VFS: Add read-only users count to superblock Valerie Aurora
2009-12-23 23:37           ` [PATCH 6/7] VFS: BUG_ON() rehash of an already hashed dentry Valerie Aurora
2009-12-23 23:37             ` [PATCH 7/7] VFS: Remove unnecessary micro-optimization in cached_lookup() Valerie Aurora
2010-01-02  0:44   ` [PATCH 1/7] autofs4: Save autofs trigger's vfsmount in super block info Ian Kent
2010-01-14  5:43     ` Al Viro
2010-01-14 19:18       ` Valerie Aurora
2010-01-15  6:05         ` Ian Kent
2010-01-15  8:03           ` Al Viro
2010-01-15 14:55             ` David Howells
2010-01-15 16:58               ` Al Viro
2010-01-15 17:08                 ` David Howells
2010-01-15 17:26                   ` Al Viro
2010-01-16 10:17                     ` Al Viro
2010-01-17 17:57                       ` Al Viro
2010-01-18  4:21                         ` Ian Kent
2010-01-18  5:59                           ` Al Viro
2010-01-18  9:14                             ` Ian Kent
2010-01-18 10:27                               ` Al Viro
2010-01-18 19:35                                 ` Trond Myklebust
2010-01-25  8:16                                   ` H. Peter Anvin [this message]
2010-01-19  7:05                                 ` Ian Kent
2010-01-15 17:36             ` Steve French
2010-01-18  5:08             ` Ian Kent

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B5D534A.4040202@zytor.com \
    --to=hpa@zytor.com \
    --cc=autofs@linux.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.