All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Sixt <j.sixt@viscovery.net>
To: Jeff King <peff@peff.net>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: [PATCH] git_connect: use use_shell instead of explicit "sh", "-c"
Date: Mon, 25 Jan 2010 13:32:44 +0100	[thread overview]
Message-ID: <4B5D8F6C.1040407@viscovery.net> (raw)

From: Johannes Sixt <j6t@kdbg.org>

This is a followup to ac0ba18 (run-command: convert simple callsites to
use_shell, 2009-12-30), for consistency.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 Jeff,

 is there a reason that this was not part of the original patch?

 -- Hannes

 connect.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/connect.c b/connect.c
index db965c9..3a12562 100644
--- a/connect.c
+++ b/connect.c
@@ -613,8 +613,7 @@ struct child_process *git_connect(int fd[2], const
char *url_orig,
 			NULL
 		};
 		conn->env = env;
-		*arg++ = "sh";
-		*arg++ = "-c";
+		conn->use_shell = 1;
 	}
 	*arg++ = cmd.buf;
 	*arg = NULL;
-- 
1.7.0.rc0.39.g31c5d

             reply	other threads:[~2010-01-25 12:32 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-25 12:32 Johannes Sixt [this message]
2010-01-25 13:01 ` [PATCH] git_connect: use use_shell instead of explicit "sh", "-c" Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B5D8F6C.1040407@viscovery.net \
    --to=j.sixt@viscovery.net \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.