From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom <Tom.Rix@windriver.com>
Date: Mon, 25 Jan 2010 08:46:23 -0600
Subject: [U-Boot] Fwd: TI:OMAP: [PATCH 5/7] Add DSS driver for OMAP3
In-Reply-To: <a8ca84ad1001250605h9dc1237k990ca21c5e6bed9d@mail.gmail.com>
References: <a8ca84ad1001180558k38f7e5fxee6c0e47ae807939@mail.gmail.com>	
	<4B5B91C3.60104@windriver.com>	
	<a8ca84ad1001250558p630a95aeuc6656d4e92cdb6b8@mail.gmail.com>
	<a8ca84ad1001250605h9dc1237k990ca21c5e6bed9d@mail.gmail.com>
Message-ID: <4B5DAEBF.2010300@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Khasim Syed Mohammed wrote:
> On Sun, Jan 24, 2010 at 5:48 AM, Tom <Tom.Rix@windriver.com> wrote:
>> Khasim Syed Mohammed wrote:
>>> From cf8fa28973de7609d27146730d9e019b7c919b51 Mon Sep 17 00:00:00 2001
>>> From: Syed Mohammed Khasim <khasim@ti.com>
>>> Date: Tue, 12 Jan 2010 23:57:28 +0530
>>> Subject: [PATCH] Add DSS driver for OMAP3
>>>
>>> Supports dynamic panel configuration
>>> Supports dynamic tv standard selection
>>> Adds support for DSS register access through generic APIs
>>>
>>> Incorporated DSS register access using structures.
>>>
>>> Previous discussions are here
>>> http://www.mail-archive.com/u-boot at lists.denx.de/msg27150.html
>>>
>>> Signed-off-by: Syed Mohammed Khasim <khasim@ti.com>
>>> ---
>>>  drivers/video/Makefile           |    1 +
>>>  drivers/video/omap3_dss.c        |  130 ++++++++++++++++++++++++++++
>>>  include/asm-arm/arch-omap3/dss.h |  173
>>> ++++++++++++++++++++++++++++++++++++++
>>>  3 files changed, 304 insertions(+), 0 deletions(-)
>>>  create mode 100644 drivers/video/omap3_dss.c
>>>  create mode 100644 include/asm-arm/arch-omap3/dss.h
>>>


<snip>

>>> +/*
>>> + * DSS Base Registers
>>> + */
>>> +#define OMAP3_DSS_BASE         0x48050040
>>> +#define OMAP3_DISPC_BASE       0x48050440
>>> +#define OMAP3_VENC_BASE                0x48050C00
>>> +
>>> +/* DSS Registers */
>>> +struct dss_regs {
>>> +       u32 control;                            /* 0x40 */
>> Add a comment to explain why base starts at 0x40
>> could also be handled with changing code
>> OMAP3_DSS_BASE 0x48050000
>> struct dss_regs {
>> u8 reserved_1[0x40];
>> ..
> may be,.. let me try.

This can just be fixed by a simple comment like
/* Note : 0x40 is offset from OMAP3_DSS_BASE */
This helps avoid people wondering why 0x40 and not 0x0

> 
>>> +       u32 sdi_control;                        /* 0x44 */
>>> +       u32 pll_control;                        /* 0x48 */
>>> +};
>>> +
>>> +/* DISPC Registers */
>>> +struct dispc_regs {
>> similar
> 
> ok
>>> +       u32 control;                            /* 0x40 */
>> Tom
> 
> Thanks for very detailed review. Mainly Licensing.

Yes.

> 
> Regards,
> Khasim

Tom