From: John Faith <john@soundmetrics.com>
To: "openembedded-devel@lists.openembedded.org"
<openembedded-devel@lists.openembedded.org>
Subject: Re: [PATCH v2] socat: Add version 1.7.1.2
Date: Mon, 25 Jan 2010 08:50:21 -0800 [thread overview]
Message-ID: <4B5DCBCD.7070500@soundmetrics.com> (raw)
In-Reply-To: <201001251025.23040.holger+oe@freyther.de>
Holger Hans Peter Freyther wrote:
> On Sunday 24 January 2010 00:16:46 John Faith wrote:
>
>> Second try. Added package source checksums, changed PR to r0, and removed
>> some trailing whitespace in the patch.
>>
>
> First of all, thank you for the contribution. I have one question. Why did you
> need to patch the configure script? It should be automatically regenerated in
> the do_configure stage?
>
>
>
Hi,
Using the default do_configure() overwrote config.h.in which lacked
#defines like HAVE_SIGACTION and broke compilation for me. I imagine
that the right thing to do would be to just to patch configure.in and
recreate the configure script and config.h.in. This page:
http://www.gnu.org/software/hello/manual/gettext/config_002eh_002ein.html
seems to indicate that its ok to manually maintain a config.h.in, so I
wonder what do_configure() should do in this case when this file is
included in the source.
,
John
next prev parent reply other threads:[~2010-01-25 16:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-23 23:16 [PATCH v2] socat: Add version 1.7.1.2 John Faith
2010-01-24 11:51 ` Paul Menzel
2010-01-25 17:54 ` John Faith
2010-01-25 9:25 ` Holger Hans Peter Freyther
2010-01-25 16:50 ` John Faith [this message]
2010-01-25 17:42 ` Khem Raj
2010-03-22 9:19 ` Holger Hans Peter Freyther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B5DCBCD.7070500@soundmetrics.com \
--to=john@soundmetrics.com \
--cc=openembedded-devel@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.