All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jochen Friedrich <jochen@scram.de>
To: Fabio Rossi <rossi.f@inwind.it>
Cc: linux-wireless@vger.kernel.org,
	Johannes Berg <johannes@sipsolutions.net>,
	John Linville <linville@tuxdriver.com>,
	Maxim Levitsky <maximlevitsky@gmail.com>
Subject: Re: [PATCH] mac80211: fix sw crypto
Date: Mon, 25 Jan 2010 23:16:07 +0100	[thread overview]
Message-ID: <4B5E1827.4040902@scram.de> (raw)
In-Reply-To: <201001252309.48260.rossi.f@inwind.it>

Fabio Rossi wrote:
> On Monday 25 January 2010 11:36:16 Johannes Berg wrote:
> 
>> What a stupid mistake. In
>>
>>     commit 813d76694043d00b59475baa1fbfaf54a2eb7fad
>>     Author: Johannes Berg <johannes@sipsolutions.net>
>>     Date:   Sun Jan 17 01:47:58 2010 +0100
>>
>>         mac80211: move control.hw_key assignment
>>
>> I inserted code testing the wrong flags field,
>> which means that the test is almost always true
>> (it's really testing for the peer's WMM support)
>> and thus the later parts of the stack assume hw
>> crypto will be done even if that's not true.
>>
>> Obviously, that broke software crypto. Maxim
>> said so specifically, and Jochen probably uses
>> some cipher that iwl3945 doesn't support in
>> hardware, which might also explain that Maxim
>> reports that even hw crypto is broken.
>>
>> Fix this to test the right flags field.
>>
> 
> Tested-by: Fabio Rossi <rossi.f@inwind.it>

Tested-by: Jochen Friedrich <jochen@scram.de>

Thanks,
Jochen

      reply	other threads:[~2010-01-25 22:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-25 10:36 [PATCH] mac80211: fix sw crypto Johannes Berg
2010-01-25 15:21 ` Maxim Levitsky
2010-01-25 15:54   ` Johannes Berg
2010-01-25 22:09 ` Fabio Rossi
2010-01-25 22:16   ` Jochen Friedrich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B5E1827.4040902@scram.de \
    --to=jochen@scram.de \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=maximlevitsky@gmail.com \
    --cc=rossi.f@inwind.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.