All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Schmidt <mail_ben_schmidt@yahoo.com.au>
To: mlmmj@mlmmj.org
Subject: PATCH: Memory leak appending original mail
Date: Tue, 26 Jan 2010 10:02:14 +0000	[thread overview]
Message-ID: <4B5EBDA6.7070501@yahoo.com.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 45 bytes --]

I found a memory leak. Patch attached.
Ben.


[-- Attachment #2: mlmmj-origmail-memleak.patch --]
[-- Type: text/x-patch, Size: 298 bytes --]

diff -r 99ec9f826d35 src/prepstdreply.c
--- a/src/prepstdreply.c	Tue Jan 26 18:25:03 2010 +1100
+++ b/src/prepstdreply.c	Tue Jan 26 20:54:10 2010 +1100
@@ -145,6 +145,7 @@
 				value = concatstr(3, value, " ", str);
 				if(tmp)
 					myfree(tmp);
+				myfree(str);
 				count++;
 			}
 			if(str)

             reply	other threads:[~2010-01-26 10:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-26 10:02 Ben Schmidt [this message]
2010-02-03  4:02 ` PATCH: Memory leak appending original mail Ben Schmidt
2010-02-16  6:15 ` Morten Shearman Kirkegaard
2010-02-16  7:35 ` Ben Schmidt
2010-02-16 17:00 ` Morten Shearman Kirkegaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B5EBDA6.7070501@yahoo.com.au \
    --to=mail_ben_schmidt@yahoo.com.au \
    --cc=mlmmj@mlmmj.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.