diff for duplicates of <4B5ED838.1080509@hhs.nl> diff --git a/a/1.txt b/N1/1.txt index ce9b124..b1600b7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -238,7 +238,7 @@ You are using multiple values from data here, you need locking around this. ### In store store_pwm_freq() / store_pwm_ast() / store_temp_st() the following: - if (newval = 255) + if (newval == 255) return count; Should return -EINVAL, as you are rejecting the value (not making any changes) @@ -252,8 +252,3 @@ Note to self all store / show functions are reviewed Regards, Hans - -_______________________________________________ -lm-sensors mailing list -lm-sensors@lm-sensors.org -http://lists.lm-sensors.org/mailman/listinfo/lm-sensors diff --git a/a/content_digest b/N1/content_digest index dff1fb6..f4e1f2c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,8 +2,8 @@ "ref\04B5B38C1.5080109@hhs.nl\0" "ref\03f9a31f41001232105l58d36ffdp8d06231f524a98ec@mail.gmail.com\0" "From\0Hans de Goede <j.w.r.degoede@hhs.nl>\0" - "Subject\0Re: [lm-sensors] Status of Andigilog asc7621 driver submitted by\0" - "Date\0Tue, 26 Jan 2010 11:55:36 +0000\0" + "Subject\0Re: [lm-sensors] Status of Andigilog asc7621 driver submitted by George Joseph on 2008-05-29\0" + "Date\0Tue, 26 Jan 2010 12:55:36 +0100\0" "To\0Jaswinder Singh Rajput <jaswinderlinux@gmail.com>\0" "Cc\0George Joseph <George.joseph@fairview5.com>" lm-sensors@lm-sensors.org @@ -251,7 +251,7 @@ "###\n" "\n" "In store store_pwm_freq() / store_pwm_ast() / store_temp_st() the following:\n" - " if (newval = 255)\n" + " if (newval == 255)\n" " return count;\n" "\n" "Should return -EINVAL, as you are rejecting the value (not making any changes)\n" @@ -264,11 +264,6 @@ "\n" "Regards,\n" "\n" - "Hans\n" - "\n" - "_______________________________________________\n" - "lm-sensors mailing list\n" - "lm-sensors@lm-sensors.org\n" - http://lists.lm-sensors.org/mailman/listinfo/lm-sensors + Hans -360da5054a11598d903e9423afede1a3b95837a57d571c96e92ca065d6f36b35 +5d5c4c6f2d44ef692fa164e79d99219d357ffb104cc3ace37ceb5d5dc81bf201
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.