From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NZl9g-0004zl-GP
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 08:08:28 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1NZl9b-0004w3-Q3
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 08:08:28 -0500
Received: from [199.232.76.173] (port=40809 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NZl9b-0004vn-Id
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 08:08:23 -0500
Received: from mail-yx0-f188.google.com ([209.85.210.188]:53116)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1NZl9b-0007WY-3u
	for qemu-devel@nongnu.org; Tue, 26 Jan 2010 08:08:23 -0500
Received: by yxe26 with SMTP id 26so3766117yxe.4
	for <qemu-devel@nongnu.org>; Tue, 26 Jan 2010 05:08:22 -0800 (PST)
Message-ID: <4B5EE944.9050602@codemonkey.ws>
Date: Tue, 26 Jan 2010 07:08:20 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] block: prevent multiwrite_merge from creating
	too large iovecs
References: <20100119211539.GA4383@lst.de> <4B56EB0F.2020409@redhat.com>
	<20100126092104.GA21528@lst.de>
In-Reply-To: <20100126092104.GA21528@lst.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org

On 01/26/2010 03:21 AM, Christoph Hellwig wrote:
> On Wed, Jan 20, 2010 at 12:37:51PM +0100, Kevin Wolf wrote:
>    
>> To underline that it's a backend/platform dependent thing: Your patch
>> breaks the mingw build for me.
>>      
> Actually that's because mingw is the usual piece of crap and doesn't
> actually have any of the vector support you can expect from a normal
> Unix system.
>
> I can either throw in an #ifdef IOV_MAX around the check or fake one up
> for mingw.  Does any of the maintainers have a preference for either
> variant?
>    

grep for CONFIG_IOVEC in qemu-common.h and add a #define IOV_MAX.

mingw doesn't have iovec so we introduce a compat version.

Regards,

Anthony Liguori