All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: "Américo Wang" <xiyou.wangcong@gmail.com>,
	"Glenn Sommer" <glemsom@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use full path to dnsdomainname and domainname in  scripts/mkcompile_h
Date: Tue, 26 Jan 2010 16:03:46 +0100	[thread overview]
Message-ID: <4B5F0452.1080306@suse.cz> (raw)
In-Reply-To: <2375c9f91001251955s1dfc70f9p94054b7824a4c4b7@mail.gmail.com>

On 26.1.2010 04:55, Américo Wang wrote:
> On Wed, Jan 20, 2010 at 11:06 PM, Glenn Sommer <glemsom@gmail.com> wrote:
>> Alternatively, if we want it to be more flexible(and allow the above)
>> - we should do something like:
>>
>> domainname_executable=`which domainname`
>> if [ ! -z "$domainname_executable" ] && [ -x "$domainname_executable" ]; then
>>

(or 'if command -v domainname >/dev/null 2>&1; then domainname ...')


> Yeah, this seems better for me.

Me too. Glenn, could you send a complete patch doing this? I'll add it
to the kbuild tree then.

Thanks,
Michal

  reply	other threads:[~2010-01-26 15:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-19 18:29 [PATCH] Use full path to dnsdomainname and domainname in scripts/mkcompile_h Glenn Sommer
2010-01-20  3:26 ` Américo Wang
2010-01-20 15:06   ` Glenn Sommer
2010-01-26  3:55     ` Américo Wang
2010-01-26 15:03       ` Michal Marek [this message]
2010-01-26 19:10         ` Glenn Sommer
2010-01-27  2:44           ` Américo Wang
2010-01-27  8:52             ` Michal Marek
2010-01-27  9:34               ` Américo Wang
     [not found]               ` <d65b1b151001270212q737706f1md00953155135b271@mail.gmail.com>
2010-01-27 10:14                 ` Glenn Sommer
2010-01-27 13:15                   ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B5F0452.1080306@suse.cz \
    --to=mmarek@suse.cz \
    --cc=glemsom@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.