From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale Date: Tue, 26 Jan 2010 19:44:57 +0100 Message-ID: <4B5F3829.5080902@grandegger.com> References: <1264408029-5290-1-git-send-email-wg@grandegger.com> <1264408029-5290-2-git-send-email-wg@grandegger.com> <1264408029-5290-3-git-send-email-wg@grandegger.com> <20100125115211.GA5257@pengutronix.de> <4B5D894C.4090001@grandegger.com> <20100125151509.GD5257@pengutronix.de> <20100126143925.GD12774@fluff.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100126143925.GD12774-elnMNo+KYs3pIgCt6eIbzw@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ben Dooks Cc: Wolfram Sang , Linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Linuxppc-dev-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Wolfgang Grandegger List-Id: linux-i2c@vger.kernel.org Ben Dooks wrote: > On Mon, Jan 25, 2010 at 04:15:09PM +0100, Wolfram Sang wrote: >>>>> >>>>> -static void __devinit mpc_i2c_setclock_52xx(struct device_node *node, >>>>> - struct mpc_i2c *i2c, >>>>> - u32 clock, u32 prescaler) >>>>> +static void __devinit mpc_i2c_setup_52xx(struct device_node *node, >>>>> + struct mpc_i2c *i2c, >>>>> + u32 clock, u32 prescaler) >>>>> { >>>>> int ret, fdr; >>>>> >>>>> + if (clock == -1) { >>>> Could we use 0 for 'no_clock'? This would make the above statement simply >>> "0" is already used to maintain backward compatibility setting a safe >>> divider. >> Ah, now I see: >> >> 'clock == -1' means 'preserve clocks' (and is checked here in mpc_i2c_setup_52xx()) >> 'clock == 0' means 'safe divider' (and is checked in mpc_i2c_get_fdr_52xx()) > > hmm, sounds like a job for a #define or similar. See v2 of this patch. Wolfgang. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <4B5F3829.5080902@grandegger.com> Date: Tue, 26 Jan 2010 19:44:57 +0100 From: Wolfgang Grandegger MIME-Version: 1.0 To: Ben Dooks Subject: Re: [PATCH 2/3] i2c-mpc: add support for the MPC512x processors from Freescale References: <1264408029-5290-1-git-send-email-wg@grandegger.com> <1264408029-5290-2-git-send-email-wg@grandegger.com> <1264408029-5290-3-git-send-email-wg@grandegger.com> <20100125115211.GA5257@pengutronix.de> <4B5D894C.4090001@grandegger.com> <20100125151509.GD5257@pengutronix.de> <20100126143925.GD12774@fluff.org.uk> In-Reply-To: <20100126143925.GD12774@fluff.org.uk> Content-Type: text/plain; charset=ISO-8859-1 Cc: Devicetree-discuss@lists.ozlabs.org, Linuxppc-dev@lists.ozlabs.org, Wolfgang Grandegger , Linux-i2c@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Ben Dooks wrote: > On Mon, Jan 25, 2010 at 04:15:09PM +0100, Wolfram Sang wrote: >>>>> >>>>> -static void __devinit mpc_i2c_setclock_52xx(struct device_node *node, >>>>> - struct mpc_i2c *i2c, >>>>> - u32 clock, u32 prescaler) >>>>> +static void __devinit mpc_i2c_setup_52xx(struct device_node *node, >>>>> + struct mpc_i2c *i2c, >>>>> + u32 clock, u32 prescaler) >>>>> { >>>>> int ret, fdr; >>>>> >>>>> + if (clock == -1) { >>>> Could we use 0 for 'no_clock'? This would make the above statement simply >>> "0" is already used to maintain backward compatibility setting a safe >>> divider. >> Ah, now I see: >> >> 'clock == -1' means 'preserve clocks' (and is checked here in mpc_i2c_setup_52xx()) >> 'clock == 0' means 'safe divider' (and is checked in mpc_i2c_get_fdr_52xx()) > > hmm, sounds like a job for a #define or similar. See v2 of this patch. Wolfgang.