All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel <qemu-devel@nongnu.org>,
	ondrej drbohlav <ondrej.drbohlav@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Musicpal: Fix wm8750 I2C address
Date: Tue, 26 Jan 2010 16:21:03 -0600	[thread overview]
Message-ID: <4B5F6ACF.3090500@codemonkey.ws> (raw)
In-Reply-To: <4B5B371A.5030408@web.de>

On 01/23/2010 11:51 AM, Jan Kiszka wrote:
> Commit b3a219883e uncovered that we attached the Wolfson with an I2C
> address shifted left by one. Fixing this makes sound work again for
> the Musicpal.
>
> Signed-off-by: Jan Kiszka<jan.kiszka@web.de>
>    
Applied to stable.  Thanks.

Regards,

Anthony Liguori
> ---
>   hw/musicpal.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/musicpal.c b/hw/musicpal.c
> index 4a33e28..e424a7d 100644
> --- a/hw/musicpal.c
> +++ b/hw/musicpal.c
> @@ -67,7 +67,7 @@
>   #define MP_AUDIO_IRQ            30
>
>   /* Wolfson 8750 I2C address */
> -#define MP_WM_ADDR              0x34
> +#define MP_WM_ADDR              0x1A
>
>   /* Ethernet register offsets */
>   #define MP_ETH_SMIR             0x010
>
>    

      parent reply	other threads:[~2010-01-26 22:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-23 17:51 [Qemu-devel] [PATCH] Musicpal: Fix wm8750 I2C address Jan Kiszka
2010-01-24  8:52 ` [Qemu-devel] " Jan Kiszka
2010-01-26 22:21 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B5F6ACF.3090500@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=jan.kiszka@web.de \
    --cc=ondrej.drbohlav@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.