From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1NZvNg-0007iF-JO for mharc-grub-devel@gnu.org; Tue, 26 Jan 2010 19:03:36 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NZvNf-0007hj-Dd for grub-devel@gnu.org; Tue, 26 Jan 2010 19:03:35 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NZvNa-0007fU-Vu for grub-devel@gnu.org; Tue, 26 Jan 2010 19:03:34 -0500 Received: from [199.232.76.173] (port=34770 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NZvNa-0007fR-OI for grub-devel@gnu.org; Tue, 26 Jan 2010 19:03:30 -0500 Received: from mail-bw0-f215.google.com ([209.85.218.215]:36058) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NZvNa-0005ak-9P for grub-devel@gnu.org; Tue, 26 Jan 2010 19:03:30 -0500 Received: by bwz7 with SMTP id 7so1997211bwz.26 for ; Tue, 26 Jan 2010 16:03:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:subject:references:in-reply-to :x-enigmail-version:content-type; bh=QHAVWs1CUwlLySYWhY7koJcLGj65+6FsVE6IAxYz1yY=; b=oTfw8k9mIVIuOMle0r4UVIodlbbplbpqaO6FA3rTAlCXempf8mZGA/H5PJZtLxeZD7 FHMx21S4U0lviD6W8Kz7WBDPatb3xmwgSIZcIL5ugYa3v2Lz6Tw2sORMCcr8EfT4vmch jtLvqtIQA0fuxNpowFMPPo+BN2JNkweVwn99I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:x-enigmail-version:content-type; b=Dyuc8sHTDqM1e8987JpuBGox9MIACtUThBTfisB8kEgs1CnHfzQ6PDktHUOeGFXX2I pU9r0c+s6IzUWc6ueyVrHubw10kXubZSHQCPwn8GIlKhcnLfM2KjZBAvq5vud2MdvmO9 UhfMdXO12SzRv2yW5+tEEQABkND0AMP/2byQU= Received: by 10.204.4.150 with SMTP id 22mr719036bkr.192.1264550609189; Tue, 26 Jan 2010 16:03:29 -0800 (PST) Received: from debian.bg45.phnet (gprs23.swisscom-mobile.ch [193.247.250.23]) by mx.google.com with ESMTPS id 16sm2919654bwz.15.2010.01.26.16.03.26 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 26 Jan 2010 16:03:27 -0800 (PST) Message-ID: <4B5F82C4.3030000@gmail.com> Date: Wed, 27 Jan 2010 01:03:16 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla-Thunderbird 2.0.0.22 (X11/20091109) MIME-Version: 1.0 To: The development of GNU GRUB References: <20100126170818.GA30854@thorin> In-Reply-To: <20100126170818.GA30854@thorin> X-Enigmail-Version: 0.95.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="------------enigC146A1590574A3DD17509E0B" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Subject: Re: PXE directory listing incorrectly reported as "success" X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2010 00:03:35 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigC146A1590574A3DD17509E0B Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Robert Millan wrote: > Hi, > > It appears that directory listing isn't supported by TFTP protocol (so > says our wiki). > > Our pxe.c implements grub_pxefs_dir() as a dummy stub that returns > GRUB_ERR_NONE. This is obviously wrong, as it prevents the user from > noticing that there was a problem, and silently reports an "empty" > directory. Instead, it should call grub_error (). > > Unfortunately, kern/fs.c relies on grub_pxefs_dir() returning > GRUB_ERR_NONE in order to consider probing to be succesful. If pxe > returned an error, it wouldn't be considered a valid filesystem by > the kernel. > =20 > So I'm wondering, what would be a good solution to this? =20 What about return GRUB_ERR_UNSUPPORTED or a separate GRUB_ERR_FS_NO_DIR which would be ignored by probing routines? > We could add > a proper probe() function and switch all filesystems to it, but only > for the benefit of pxe it seems a bit overkill. > > Does someone have a better idea? > > =20 --=20 Regards Vladimir '=CF=86-coder/phcoder' Serbinenko --------------enigC146A1590574A3DD17509E0B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iF4EAREKAAYFAktfgssACgkQNak7dOguQglMcAD/ZIJ669c0WgZsPVmcAyiKOflF 8p979CdDJeCXh6rQR+IBAJXaoB5gsWjHcJwc/3Pgiow3FT+iUmf/6NJZyARObuin =sQ2x -----END PGP SIGNATURE----- --------------enigC146A1590574A3DD17509E0B--