From: Clemens Ladisch <clemens@ladisch.de>
To: Jaroslav Kysela <perex@perex.cz>
Cc: alsa-devel@alsa-project.org
Subject: Re: hw_ptr_interrupt removal broke interrupt pointer updates
Date: Wed, 27 Jan 2010 10:49:50 +0100 [thread overview]
Message-ID: <4B600C3E.6090208@ladisch.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1001261713430.6542@eeebox2.perex-int.cz>
Jaroslav Kysela wrote:
> I returned hw_ptr_interrupt variable back. I am testing this patch now:
>
> http://git.alsa-project.org/?p=alsa-kernel.git;a=commitdiff;h=04d64a69fcb9fd182d73d6f1a8de55b2f527a1de
>
> A review is always welcome. Thanks.
The patch looks fine, and it works again now.
A somewhat unrelated issue: Both old and new code assume that
hw_ptr==0 is a period boundary, but that is not true if the boundary
is not an integer multiple of the period size, and the pointer wraps.
I'm not sure what happens then.
Best regards,
Clemens
next prev parent reply other threads:[~2010-01-27 9:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 13:39 hw_ptr_interrupt removal broke interrupt pointer updates Clemens Ladisch
2010-01-26 16:16 ` Jaroslav Kysela
2010-01-27 3:09 ` Raymond Yau
2010-01-27 7:06 ` Jaroslav Kysela
2010-01-27 9:49 ` Clemens Ladisch [this message]
2010-01-27 10:11 ` Jaroslav Kysela
2010-01-27 14:12 ` Clemens Ladisch
2010-01-27 17:21 ` Jaroslav Kysela
2010-02-01 15:33 ` Colin Guthrie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B600C3E.6090208@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.