All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfstests: Automatic build dependency calculations
Date: Wed, 27 Jan 2010 13:25:33 -0600	[thread overview]
Message-ID: <4B60932D.7060709@sandeen.net> (raw)
In-Reply-To: <1264053773-6054-3-git-send-email-david@fromorbit.com>

Dave Chinner wrote:
> Currently the xfstest builds do not have any automatic dependency
> calculations. It relies on a separate make depend run to build or
> update dependency information. It also relies on an external
> makedepend binary. If that binary does not exist, the dependencies
> do not get calculated.
> 
> To remove the dependency on makedepend, gcc can be used instead as
> it has a command to generate dependency information. This patch
> changes the dependency rule building to use gcc.
> 
> In case anyone uses an old (several years) gcc compiler or a
> compiler that doesn't support gcc compatible dependency generation,
> a new configure check is added to turn off dependency checking so
> builds can still be done.
> 
> To use the dependencies automatically, we need to use a special
> include makefile directive to include the build dependencies into
> the current makefile.  Essentially once the dependencies are
> calculated, they can be included into the makefile and make will
> recalculate the build dependencies automatically based on that
> information.
> 
> Hence we get a build that automatically calculates and keeps
> dependencies up to date without dependence on any external tools.
> 
> Signed-off-by: Dave Chinner <david@fromorbit.com>

seems to be some fallout from this at least on my F10 box:

/usr/bin/makedepend: warning:  ignoring option -Wall
/usr/bin/makedepend: error:  cannot open "no-strict-aliasing"

also this change:

-       preallo_rw_pattern_reader preallo_rw_pattern_writer ftrunc trunc \
-       fs_perms testx looptest locktest unwritten_mmap \
+       ftrunc trunc fs_perms testx looptest locktest unwritten_mmap \
        bulkstat_unlink_test bulkstat_unlink_test_modified t_dir_offset \

...


+PREALLO_TARGETS = preallo_rw_pattern_reader

seems to have lost the build of preallo_rw_pattern_reader & writer.

Was that stray, or what were you going for there?

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  parent reply	other threads:[~2010-01-27 19:24 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-21  6:02 [PATCH 0/2] xfstests: Automatic build dependencies Dave Chinner
2010-01-21  6:02 ` [PATCH 1/2] xfstests: rebuild aclocal.m4 Dave Chinner
2010-01-21 11:21   ` Christoph Hellwig
2010-01-24  7:16     ` Dave Chinner
2010-01-21  6:02 ` [PATCH 2/2] xfstests: Automatic build dependency calculations Dave Chinner
2010-01-21 11:24   ` Christoph Hellwig
2010-01-24  7:17     ` Dave Chinner
2010-01-27 19:25   ` Eric Sandeen [this message]
2010-01-27 20:17     ` Christoph Hellwig
2010-01-27 20:20       ` Eric Sandeen
2010-01-27 20:26         ` [PATCH] xfstests: fix compilation of iopat targets Christoph Hellwig
2010-01-27 20:29           ` Eric Sandeen
2010-01-27 22:57     ` [PATCH 2/2] xfstests: Automatic build dependency calculations Dave Chinner
2010-01-27 23:06       ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B60932D.7060709@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=david@fromorbit.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.