From: john cooper <john.cooper@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
john.cooper@redhat.com, Rusty Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org,
Christian Borntraeger <borntraeger@de.ibm.com>
Subject: [Qemu-devel] Re: future of the virtio-blk serial number support
Date: Thu, 28 Jan 2010 11:38:47 -0500 [thread overview]
Message-ID: <4B61BD97.4020202@redhat.com> (raw)
In-Reply-To: <20100128124327.GA32288@lst.de>
Christoph Hellwig wrote:
> Back iSeptember 2007 Michael made the serial number support in qemu
> optional and off by default, and in October 2009 Rusty reverted the
> Linux virtio-blk support for it. Given that I can't find support in
> any other virtio implementation that makes the feature look essentially
> dead.
>
> How should we proceed with adding more fields to struct virtio_blk_config?
> I would suggest removing the identity field, declaring
> VIRTIO_BLK_F_IDENTIFY officially deprecated and adding the new fields
> directly after blk_size again, maybe with a comment that these new
> features can't be advertized together with VIRTIO_BLK_F_IDENTIFY.
Agreed. Feel free to remove it from the PCI
config space. Its an artifact at this point
and I wouldn't even worry about deprecating
it.
-john
--
john.cooper@redhat.com
next prev parent reply other threads:[~2010-01-28 16:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 12:43 [Qemu-devel] future of the virtio-blk serial number support Christoph Hellwig
2010-01-28 13:50 ` [Qemu-devel] " Michael S. Tsirkin
2010-01-28 14:09 ` Anthony Liguori
2010-01-28 16:38 ` john cooper [this message]
2010-01-28 20:59 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B61BD97.4020202@redhat.com \
--to=john.cooper@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=hch@lst.de \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.