From: "H. Peter Anvin" <hpa@zytor.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: torvalds@linux-foundation.org, akpm@linux-foundation.org,
security@kernel.org, tony.luck@intel.com, jmorris@namei.org,
mikew@google.com, md@google.com, linux-mm@kvack.org,
mingo@redhat.com, tglx@linutronix.de, minipli@googlemail.com,
roland@redhat.com
Subject: Re: [PATCH 2/2] x86: get rid of the insane TIF_ABI_PENDING bit
Date: Thu, 28 Jan 2010 21:44:39 -0800 [thread overview]
Message-ID: <4B6275C7.2040807@zytor.com> (raw)
In-Reply-To: <1264743694-4586-2-git-send-email-hpa@zytor.com>
On 01/28/2010 09:41 PM, H. Peter Anvin wrote:
>
> #ifdef CONFIG_X86_64
> - if (test_tsk_thread_flag(tsk, TIF_ABI_PENDING)) {
> - clear_tsk_thread_flag(tsk, TIF_ABI_PENDING);
> - if (test_tsk_thread_flag(tsk, TIF_IA32)) {
> - clear_tsk_thread_flag(tsk, TIF_IA32);
> - } else {
> - set_tsk_thread_flag(tsk, TIF_IA32);
> - current_thread_info()->status |= TS_COMPAT;
> - }
> - }
> + /* Set up the first "return" to user space */
> + if (test_tsk_thread_flag(tsk, TIF_IA32))
> + current_thread_info()->status |= TS_COMPAT;
> #endif
>
This chunk should of course have been completely removed... let me do
that and re-test.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-01-29 5:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 7:34 DoS on x86_64 Mathias Krause
2010-01-28 8:18 ` [Security] " Andrew Morton
2010-01-28 15:41 ` H. Peter Anvin
2010-01-28 22:33 ` Linus Torvalds
2010-01-28 22:47 ` Mathias Krause
2010-01-28 22:47 ` H. Peter Anvin
2010-01-28 23:09 ` Linus Torvalds
2010-01-28 23:27 ` H. Peter Anvin
2010-01-28 23:46 ` Linus Torvalds
2010-01-29 4:43 ` Linus Torvalds
2010-01-29 4:43 ` [PATCH 1/2] Split 'flush_old_exec' into two functions Linus Torvalds
2010-01-29 4:47 ` [PATCH 2/2] x86: get rid of the insane TIF_ABI_PENDING bit Linus Torvalds
2010-01-29 5:17 ` [PATCH 1/2] Split 'flush_old_exec' into two functions H. Peter Anvin
2010-01-29 5:05 ` [Security] DoS on x86_64 H. Peter Anvin
2010-01-29 5:29 ` H. Peter Anvin
2010-01-29 5:34 ` [PATCH 1/2] Split 'flush_old_exec' into two functions H. Peter Anvin
2010-01-29 5:34 ` [PATCH 2/2] x86: get rid of the insane TIF_ABI_PENDING bit H. Peter Anvin
2010-01-29 5:36 ` [PATCH 1/2] Split 'flush_old_exec' into two functions H. Peter Anvin
2010-01-29 5:36 ` [PATCH 2/2] x86: get rid of the insane TIF_ABI_PENDING bit H. Peter Anvin
2010-01-29 5:41 ` [PATCH 1/2] Split 'flush_old_exec' into two functions H. Peter Anvin
2010-01-29 5:41 ` [PATCH 2/2] x86: get rid of the insane TIF_ABI_PENDING bit H. Peter Anvin
2010-01-29 5:44 ` H. Peter Anvin [this message]
2010-01-29 6:14 ` [PATCH 1/2] Split 'flush_old_exec' into two functions H. Peter Anvin
2010-01-29 6:14 ` [PATCH 2/2] x86: get rid of the insane TIF_ABI_PENDING bit H. Peter Anvin
2010-01-28 23:06 ` [Security] DoS on x86_64 Linus Torvalds
2010-01-28 23:14 ` H. Peter Anvin
2010-01-28 21:31 ` Mathias Krause
2010-01-28 17:10 ` Linus Torvalds
2010-01-28 21:49 ` Mathias Krause
2010-01-28 21:58 ` Linus Torvalds
2010-01-28 22:08 ` Mathias Krause
2010-01-28 22:18 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6275C7.2040807@zytor.com \
--to=hpa@zytor.com \
--cc=akpm@linux-foundation.org \
--cc=jmorris@namei.org \
--cc=linux-mm@kvack.org \
--cc=md@google.com \
--cc=mikew@google.com \
--cc=mingo@redhat.com \
--cc=minipli@googlemail.com \
--cc=roland@redhat.com \
--cc=security@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.