From: Stephen Boyd <bebarino@gmail.com>
To: Thiago Farina <tfransosi@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtin-name-rev.c: remove the remaining "typedef struct rev_name" from git.
Date: Fri, 29 Jan 2010 23:53:16 -0800 [thread overview]
Message-ID: <4B63E56C.5000100@gmail.com> (raw)
In-Reply-To: <8678db190a73997c7bd757b9d78f0fa9e8721055.1264815015.git.tfransosi@gmail.com>
On 01/29/2010 05:32 PM, Thiago Farina wrote:
> @@ -43,7 +43,7 @@ static void name_rev(struct commit *commit,
> }
>
> if (name == NULL) {
> - name = xmalloc(sizeof(rev_name));
> + name = xmalloc(sizeof(struct rev_name));
How about sizeof(*name) instead? This way we don't have to change it
when the type changes again.
prev parent reply other threads:[~2010-01-30 7:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-30 1:32 [PATCH] builtin-name-rev.c: remove the remaining "typedef struct rev_name" from git Thiago Farina
2010-01-30 7:53 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B63E56C.5000100@gmail.com \
--to=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=tfransosi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.