From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roel Kluin Date: Sun, 31 Jan 2010 17:53:35 +0100 Subject: [Ocfs2-devel] ocfs2: ei_cpos/phys confusion? Message-ID: <4B65B58F.1010601@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ocfs2-devel@oss.oracle.com in ocfs2_try_to_merge_extent_map(), vi fs/ocfs2/extent_map.c +185 if (ins->ei_phys == (emi->ei_phys + emi->ei_clusters) && ins->ei_cpos == (emi->ei_cpos + emi->ei_clusters) && ins->ei_flags == emi->ei_flags) { emi->ei_clusters += ins->ei_clusters; return 1; } else if ((ins->ei_phys + ins->ei_clusters) == emi->ei_phys && (ins->ei_cpos + ins->ei_clusters) == emi->ei_phys && ----------------------------------------------------------------^^^^ ins->ei_flags == emi->ei_flags) { emi->ei_phys = ins->ei_phys; emi->ei_cpos = ins->ei_cpos; emi->ei_clusters += ins->ei_clusters; return 1; } should that 2nd emi->ei_phys be emi->ei_cpos? Roel