From: Bruce Dubbs <bruce.dubbs@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] Fix a special case when accessing partition on linux
Date: Sun, 31 Jan 2010 14:22:50 -0600 [thread overview]
Message-ID: <4B65E69A.4010106@gmail.com> (raw)
In-Reply-To: <4B65E178.4050002@gmail.com>
Vladimir 'φ-coder/phcoder' Serbinenko wrote:
> Because of cache coherency problem grub accesses partitions on linux by
> hdaX device and not by hda with correct offset. The problem is that
> because of 4K cache blocks disk.c may read sectors before the partition
> and hence making hostdisk.c try to read from negative offset. I'm sad
> that we need such workarounds for free systems.
I would think it beneficial for long term code maintenance to put
the above comments into the code itself.
// Because of a cache coherency problem grub accesses partitions
// on linux by an hdaX device and not by hda with the correct offset.
// The problem is that because of 4K cache blocks, disk.c may
// read sectors before the partition and hence make
// hostdisk.c try to read from a negative offset.
-- Bruce
prev parent reply other threads:[~2010-01-31 20:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-31 20:00 [PATCH] Fix a special case when accessing partition on linux Vladimir 'φ-coder/phcoder' Serbinenko
2010-01-31 20:22 ` Bruce Dubbs [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B65E69A.4010106@gmail.com \
--to=bruce.dubbs@gmail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.