From: Mike Christie <michaelc@cs.wisc.edu>
To: Ravi Anand <ravi.anand@qlogic.com>
Cc: James Bottomley <james.bottomley@suse.de>,
Linux-SCSI Mailing List <linux-scsi@vger.kernel.org>,
Karen Higgins <karen.higgins@qlogic.com>,
Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Subject: Re: [PATCH 06/11] qla4xxx: added srb referance counter
Date: Mon, 01 Feb 2010 12:22:52 -0600 [thread overview]
Message-ID: <4B671BFC.90107@cs.wisc.edu> (raw)
In-Reply-To: <20100130062856.GG10274@linux-qf4p>
On 01/30/2010 12:28 AM, Ravi Anand wrote:
>
> - msleep(2000);
> - } while (max_wait_time--);
> + if (got_ref&& (atomic_read(&rp->ref_count) == 1)) {
> + done++;
> + break;
> + }
> +
> + msleep(ABORT_POLLING_PERIOD);
Did you want to use krefs for the refcounting?
And why is this so funky (got_ref arg and refcount peak) compared to the
qla2xxx one?
next prev parent reply other threads:[~2010-02-01 18:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-30 6:28 [PATCH 06/11] qla4xxx: added srb referance counter Ravi Anand
2010-02-01 18:22 ` Mike Christie [this message]
2010-02-11 11:08 ` Ravi Anand
2010-02-11 22:57 ` Mike Christie
2010-02-11 23:02 ` Mike Christie
[not found] ` <0CB616B0-0903-41A0-9ADD-5DD64989FFD1@qlogic.com>
2010-02-11 23:54 ` Mike Christie
2010-02-12 0:06 ` Mike Christie
2010-02-12 0:48 ` Mike Christie
2010-02-12 17:29 ` Mike Christie
2010-02-12 18:19 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B671BFC.90107@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=james.bottomley@suse.de \
--cc=karen.higgins@qlogic.com \
--cc=linux-scsi@vger.kernel.org \
--cc=ravi.anand@qlogic.com \
--cc=vikas.chaudhary@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.