From: Joonyoung Shim <jy0922.shim@samsung.com>
To: broonie@opensource.wolfsonmicro.com
Cc: kyungmin.park@samsung.com, alsa-devel@alsa-project.org,
Joonyoung Shim <jy0922.shim@samsung.com>,
cw00.choi@samsung.com
Subject: Re: [PATCH] ASoC: Fix BCLK calculation of WM8994
Date: Tue, 02 Feb 2010 18:53:19 +0900 [thread overview]
Message-ID: <4B67F60F.4090803@samsung.com> (raw)
In-Reply-To: <4B67F35D.905@samsung.com>
On 2/2/2010 6:41 PM, Joonyoung Shim wrote:
> Content-Type: text/plain; charset=UTF-8
> Content-Transfer-Encoding: 7bit
>
> This fixes BCLK calculation and removes unnecessary check code.
>
> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
Sorry, dummy texts were added. Please use below patch.
>From a531baaf93e3514f92a290a2e0bdd5ea5d928a4b Mon Sep 17 00:00:00 2001
From: Joonyoung Shim <jy0922.shim@samsung.com>
Date: Tue, 2 Feb 2010 18:05:42 +0900
Subject: [PATCH] ASoC: Fix BCLK calculation of WM8994
This fixes BCLK calculation and removes unnecessary check code.
Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com>
---
sound/soc/codecs/wm8994.c | 7 ++-----
1 files changed, 2 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/wm8994.c b/sound/soc/codecs/wm8994.c
index 5dd4b29..29f3771 100644
--- a/sound/soc/codecs/wm8994.c
+++ b/sound/soc/codecs/wm8994.c
@@ -3267,15 +3267,12 @@ static int wm8994_hw_params(struct snd_pcm_substream *substream,
*/
best = 0;
for (i = 0; i < ARRAY_SIZE(bclk_divs); i++) {
- if (bclk_divs[i] < 0)
- continue;
- cur_val = (wm8994->aifclk[id] * 10 / bclk_divs[i])
- - bclk_rate * 10;
+ cur_val = (wm8994->aifclk[id] * 10 / bclk_divs[i]) - bclk_rate;
if (cur_val < 0) /* BCLK table is sorted */
break;
best = i;
}
- bclk_rate = wm8994->aifclk[id] / bclk_divs[best];
+ bclk_rate = wm8994->aifclk[id] * 10 / bclk_divs[best];
dev_dbg(dai->dev, "Using BCLK_DIV %d for actual BCLK %dHz\n",
bclk_divs[best], bclk_rate);
bclk |= best << WM8994_AIF1_BCLK_DIV_SHIFT;
--
1.6.3.3
next prev parent reply other threads:[~2010-02-02 9:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 9:41 [PATCH] ASoC: Fix BCLK calculation of WM8994 Joonyoung Shim
2010-02-02 9:53 ` Joonyoung Shim [this message]
2010-02-02 11:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B67F60F.4090803@samsung.com \
--to=jy0922.shim@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=cw00.choi@samsung.com \
--cc=kyungmin.park@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.