From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andre Przywara Subject: Re: [PATCH] Add cpu model configuration support.. (resend) Date: Tue, 2 Feb 2010 11:17:26 +0100 Message-ID: <4B67FBB6.6010400@amd.com> References: <4B672535.5050303@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: KVM list , qemu-devel@nongnu.org, donald.d.dugger@intel.com, Anthony Liguori To: john cooper Return-path: Received: from va3ehsobe002.messaging.microsoft.com ([216.32.180.12]:12912 "EHLO VA3EHSOBE002.bigfish.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751887Ab0BBKSA (ORCPT ); Tue, 2 Feb 2010 05:18:00 -0500 In-Reply-To: <4B672535.5050303@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: john cooper wrote: > [target-x86_64.conf was unintentionally omitted from the earlier patch] > > This is a reimplementation of prior versions which adds > the ability to define cpu models for contemporary processors. > The added models are likewise selected via -cpu , > and are intended to displace the existing convention > of "-cpu qemu64" augmented with a series of feature flags. > ... John, first I would like to apologize for sending out my patch series although I know that it heavily conflicts with yours. Actually you beat me just by hours with yours, I had mine ready on Friday evening and just delayed the sending until Monday ;-) Can you split up the patch into a series of smaller ones (maybe git add -i can help you here?). This version is a bit large for proper review and mixes fixes and feature additions. Additionally this would help to merge our both versions. Regards, Andre. -- Andre Przywara AMD-Operating System Research Center (OSRC), Dresden, Germany Tel: +49 351 448 3567 12 ----to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd; Thomas M. McCoy; Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NcFpt-0000WZ-Rc for qemu-devel@nongnu.org; Tue, 02 Feb 2010 05:18:22 -0500 Received: from [199.232.76.173] (port=57056 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NcFpt-0000WF-7v for qemu-devel@nongnu.org; Tue, 02 Feb 2010 05:18:21 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NcFph-0001Qx-5B for qemu-devel@nongnu.org; Tue, 02 Feb 2010 05:18:21 -0500 Received: from va3ehsobe002.messaging.microsoft.com ([216.32.180.12]:12978 helo=VA3EHSOBE002.bigfish.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_MD5:16) (Exim 4.60) (envelope-from ) id 1NcFpg-0001OU-22 for qemu-devel@nongnu.org; Tue, 02 Feb 2010 05:18:08 -0500 Message-ID: <4B67FBB6.6010400@amd.com> Date: Tue, 2 Feb 2010 11:17:26 +0100 From: Andre Przywara MIME-Version: 1.0 References: <4B672535.5050303@redhat.com> In-Reply-To: <4B672535.5050303@redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Add cpu model configuration support.. (resend) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: john cooper Cc: qemu-devel@nongnu.org, KVM list john cooper wrote: > [target-x86_64.conf was unintentionally omitted from the earlier patch] > > This is a reimplementation of prior versions which adds > the ability to define cpu models for contemporary processors. > The added models are likewise selected via -cpu , > and are intended to displace the existing convention > of "-cpu qemu64" augmented with a series of feature flags. > ... John, first I would like to apologize for sending out my patch series although I know that it heavily conflicts with yours. Actually you beat me just by hours with yours, I had mine ready on Friday evening and just delayed the sending until Monday ;-) Can you split up the patch into a series of smaller ones (maybe git add -i can help you here?). This version is a bit large for proper review and mixes fixes and feature additions. Additionally this would help to merge our both versions. Regards, Andre. -- Andre Przywara AMD-Operating System Research Center (OSRC), Dresden, Germany Tel: +49 351 448 3567 12 ----to satisfy European Law for business letters: Advanced Micro Devices GmbH Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen Geschaeftsfuehrer: Andrew Bowd; Thomas M. McCoy; Giuliano Meroni Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen Registergericht Muenchen, HRB Nr. 43632