From: Patrick McHardy <kaber@trash.net>
To: Simon Arlott <simon@fire.lp0.eu>
Cc: Jan Engelhardt <jengelh@medozas.de>,
William Allen Simpson <william.allen.simpson@gmail.com>,
netdev <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH] xt_TCPMSS: SYN packets are allowed to contain data
Date: Tue, 02 Feb 2010 15:34:19 +0100 [thread overview]
Message-ID: <4B6837EB.3030902@trash.net> (raw)
In-Reply-To: <4B58B578.9080505@simon.arlott.org.uk>
Simon Arlott wrote:
> The TCPMSS target is dropping SYN packets where:
> 1) There is data, or
> 2) The data offset makes the TCP header larger than the packet.
>
> Both of these result in an error level printk. This printk has been
> removed.
>
> This change avoids dropping SYN packets containing data. If there
> is also no MSS option (as well as data), one will not be added
> because of possible complications due to the increased packet size.
Applied, thanks Simon.
prev parent reply other threads:[~2010-02-02 14:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 21:08 [PATCH] xt_TCPMSS: SYN packets are allowed to contain data Simon Arlott
2010-01-19 9:17 ` William Allen Simpson
2010-01-19 9:30 ` Patrick McHardy
2010-01-19 12:43 ` Simon Arlott
2010-01-19 12:53 ` Patrick McHardy
2010-01-19 12:50 ` Simon Arlott
2010-01-19 15:44 ` William Allen Simpson
2010-01-20 12:59 ` Simon Arlott
2010-01-20 21:21 ` Simon Arlott
2010-01-20 21:39 ` Jan Engelhardt
2010-01-20 21:41 ` Jan Engelhardt
2010-01-20 21:51 ` Simon Arlott
2010-01-20 22:22 ` Amos Jeffries
2010-01-20 23:14 ` Patrick McHardy
2010-01-21 12:47 ` Simon Arlott
2010-01-21 12:58 ` Jan Engelhardt
2010-01-21 13:02 ` Patrick McHardy
2010-01-21 20:13 ` Simon Arlott
2010-02-02 14:34 ` Patrick McHardy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6837EB.3030902@trash.net \
--to=kaber@trash.net \
--cc=jengelh@medozas.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=simon@fire.lp0.eu \
--cc=william.allen.simpson@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.