All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Greg KH <greg@kroah.com>,
	Matthew Dharm <mdharm-kernel@one-eyed-alien.net>
Subject: Re: [PATCH] isp1760: Flush the D-cache for the pipe-in transfer  buffers
Date: Tue, 02 Feb 2010 16:54:22 +0100	[thread overview]
Message-ID: <4B684AAE.9020609@linutronix.de> (raw)
In-Reply-To: <d82e647a1002020741n4a048395o6ebf7ffaf8457819@mail.gmail.com>

Ming Lei wrote:
> 2010/2/2 Catalin Marinas <catalin.marinas@arm.com>:
> 
>> +       if (usb_pipein(urb->pipe) && usb_pipetype(urb->pipe) == PIPE_BULK) {
>> +               void *ptr;
>> +               for (ptr = urb->transfer_buffer;
>> +                    ptr < urb->transfer_buffer + urb->transfer_buffer_length;
>> +                    ptr += PAGE_SIZE)
>> +                       flush_dcache_page(virt_to_page(ptr));
> 
> If the page is mapped into highmem, seems virt_to_page doesn't work well.

This does not matter because this can not happen :). If the buffer is
highmem then a bounce buffer is used. See commit 96983d2d8 aka "USB:
storage: set bounce limit for non-DMA-capable host controllers"


Sebastian

      parent reply	other threads:[~2010-02-02 15:54 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-02 11:11 [PATCH] isp1760: Flush the D-cache for the pipe-in transfer buffers Catalin Marinas
2010-02-02 12:08 ` Sebastian Andrzej Siewior
2010-02-02 15:28   ` Catalin Marinas
2010-02-02 15:41 ` Ming Lei
2010-02-02 15:54   ` Catalin Marinas
2010-02-02 15:54   ` Sebastian Andrzej Siewior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B684AAE.9020609@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=catalin.marinas@arm.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mdharm-kernel@one-eyed-alien.net \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.