From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Richter Subject: Re: [PATCH 05/10] drivers/scsi/arcmsr: Fix continuation line formats Date: Tue, 02 Feb 2010 19:20:28 +0100 Message-ID: <4B686CEC.4000107@s5r6.in-berlin.de> References: <1a318fa326c6ab2584b9d318bd1538e7f7debbdf.1264967499.git.joe@perches.com> <1a318fa326c6ab2584b9d318bd1538e7f7debbdf.1264967499.git.joe@perches.com> <1265044616.6910.15.camel@mulgrave.site> <201002011902.33015.elendil@planet.nl> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201002011902.33015.elendil@planet.nl> Sender: linux-kernel-owner@vger.kernel.org To: Frans Pop Cc: James Bottomley , joe@perches.com, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org List-Id: linux-scsi@vger.kernel.org Frans Pop wrote: > James Bottomley wrote: >>> - printk(KERN_NOTICE "arcmsr%d: wait 'flush adapter cache' \ >>> - timeout, retry count down = %d \n", acb->host->host_no, retry_count); >> >> So I might personally dislike this style > > The problem here is not style, but that the whitespace of the indentation > on the second line becomes part of the output! > That makes the code defective and is why Joe posted the patch series. Joe could have pointed this out in the changelog. s/are not good/incorporate unintended whitespace/ [James wrote:] >> Why? It's perfectly valid ansi C. Its syntax is valid but not its semantics. >> Consider this change veto'd unless you can get an explicit ack from the >> current maintainer for changing their style. How about the maintainer takes the fix patch and adjusts style to his liking? (That's what I would do because I like fix submissions.) -- Stefan Richter -=====-==-=- --=- ---=- http://arcgraph.de/sr/