From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [patch 1/1] net/ipv4/netfilter/nf_nat_snmp_basic.c: correct the size argument to kzalloc Date: Wed, 03 Feb 2010 01:42:15 +0100 Message-ID: <4B68C667.7010204@trash.net> References: <201002022244.o12MiZGL019252@imap1.linux-foundation.org> <4B68C540.1060008@trash.net> <20100202163948.fa2c8d1a.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100202163948.fa2c8d1a.akpm@linux-foundation.org> Sender: netfilter-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Andrew Morton Cc: netfilter@vger.kernel.org, julia@diku.dk, davem@davemloft.net Andrew Morton wrote: > On Wed, 03 Feb 2010 01:37:20 +0100 > Patrick McHardy wrote: > >> akpm@linux-foundation.org wrote: >>> From: Julia Lawall >>> >>> obj has type struct snmp_object **, not struct snmp_object *. But indeed >>> it is not even clear why kmalloc is needed. The memory is freed by the >>> end of the function, so the local variable of pointer type should be >>> sufficient. >> This one is already queued in nf-next-2.6.git. > > Recently? It wasn't in today's linux-next. > Actually I haven't merged it to Dave yet, but I will do so soon. Its queued and safe however :)