All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] xfstests: routine to create scratch of certain size
Date: Tue, 02 Feb 2010 20:49:23 -0600	[thread overview]
Message-ID: <4B68E433.9050309@sandeen.net> (raw)
In-Reply-To: <4B68D75A.9020105@sandeen.net>

Eric Sandeen wrote:
> This is needed for later enospc tests to be generic
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
> 
> V2: Address Christoph's comment about use of MKFS_OPTIONS;
> just do it like the other geom helper and explicitly -set-
> MKFS_OPTIONS for scratch, to set the size, then just call
> _scratch_mkfs
> 
> (this would override any global MKFS_OPTIONS setting, but
> I think that's ok for now, and not sure how these options might
> interact w/ previously set MKFS_OPTIONS anyway)

Scratch that, I'm not being diligent enough and didn't test
this :/  (yay for "simple" changes)

mke2fs takes the size arg at the end, after the device, so
we cannot just set up MKFS_OPTIONS

Sorry for the noise.

-Eric (who will try to be more dilient now...)

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

      reply	other threads:[~2010-02-03  2:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-28 23:28 [PATCH] xfstests: routine to create scratch of certain size Eric Sandeen
2010-01-30 10:19 ` Christoph Hellwig
2010-01-30 16:03   ` Eric Sandeen
2010-02-03  1:54 ` [PATCH V2] " Eric Sandeen
2010-02-03  2:49   ` Eric Sandeen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B68E433.9050309@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.