From: Dan Williams <dan.j.williams@intel.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/3 v3] sh: fix Transfer Size calculation in both DMA
Date: Wed, 03 Feb 2010 07:05:13 +0000 [thread overview]
Message-ID: <4B692029.8020508@intel.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1002011958290.4617@axis700.grange>
Guennadi Liakhovetski wrote:
> Both the original arch/sh/drivers/dma/dma-sh.c and the new SH dmaengine drivers
> do not take into account bits 3:2 of the Transfer Size field in the CHCR
> register, besides, bit-field defines set bit 2, but the mask only passes bits
> 1:0 through. TS_16BLK and TS_32BLK macros are bogus too. This patch fixes all
> these issues for sh7722 and sh7724, other CPUs stay unchanged and might need to
> be fixed too.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
>
> v2 -> v3:
> 1. Also fix sh3, compile-tested for hp6xx_defconfig
> 2. Rename CHCR_TS01_* to CHCR_TS_LOW_* and CHCR_TS23_* to CHCR_TS_HIGH_*
>
> This should be the last "fix compile-breakage" revision, sorry for a
> patch-flood
>
> arch/sh/drivers/dma/dma-sh.c | 5 +-
This bit collides with 9d56dd3b "sh: Mass ctrl_in/outX to
__raw_read/writeX conversion." in Paul's tree. I'm fine with these
going through the sh tree with my acked-by modulo that minor nit with
the dma_list_mutex comment in 3/3.
--
Dan
next prev parent reply other threads:[~2010-02-03 7:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 19:03 [PATCH 2/3 v3] sh: fix Transfer Size calculation in both DMA drivers Guennadi Liakhovetski
2010-02-02 23:59 ` [PATCH 2/3 v3] sh: fix Transfer Size calculation in both DMA Dan Williams
2010-02-03 0:16 ` Guennadi Liakhovetski
2010-02-03 7:05 ` Dan Williams [this message]
2010-02-03 17:58 ` Dan Williams
2010-02-03 22:26 ` [PATCH 2/3 v3] sh: fix Transfer Size calculation in both DMA drivers Paul Mundt
2010-02-04 1:47 ` [PATCH 2/3 v3] sh: fix Transfer Size calculation in both DMA Dan Williams
2010-02-04 5:26 ` [PATCH 2/3 v3] sh: fix Transfer Size calculation in both DMA drivers Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B692029.8020508@intel.com \
--to=dan.j.williams@intel.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.