From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mauro Carvalho Chehab Date: Wed, 03 Feb 2010 14:28:19 +0000 Subject: Re: [PATCH 3/8] drivers/media/video/hdpvr: introduce missing kfree Message-Id: <4B698803.7010805@infradead.org> List-Id: References: <20090916111325.GA14900@aniel.lan> <4B684273.6040500@infradead.org> <20100203141210.GD7946@aniel.lan> In-Reply-To: <20100203141210.GD7946@aniel.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Janne Grunau Cc: Julia Lawall , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Janne Grunau wrote: > Hej, > > On Tue, Feb 02, 2010 at 01:19:15PM -0200, Mauro Carvalho Chehab wrote: >> Janne Grunau wrote: >>> On Fri, Sep 11, 2009 at 06:21:35PM +0200, Julia Lawall wrote: >>>> Error handling code following a kzalloc should free the allocated data. >>> Thanks for the report. I'll commit a different patch which adds the buffer >>> to the buffer list as soon it is allocated. The hdpvr_free_buffers() in the >>> error handling code will clean it up then. See below: >> Any news about this subject? The current upstream code still misses the change bellow > > it was fixed differently in cd0e280f Thanks! I'm removing it from my queue :) Now, the only hdpvr patch is this one: hdpvr-video: cleanup signedness http://patchwork.kernel.org/patch/74902 Cheers, Mauro From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754519Ab0BCO21 (ORCPT ); Wed, 3 Feb 2010 09:28:27 -0500 Received: from bombadil.infradead.org ([18.85.46.34]:42765 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751838Ab0BCO2Z (ORCPT ); Wed, 3 Feb 2010 09:28:25 -0500 Message-ID: <4B698803.7010805@infradead.org> Date: Wed, 03 Feb 2010 12:28:19 -0200 From: Mauro Carvalho Chehab User-Agent: Thunderbird 2.0.0.22 (X11/20090609) MIME-Version: 1.0 To: Janne Grunau CC: Julia Lawall , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 3/8] drivers/media/video/hdpvr: introduce missing kfree References: <20090916111325.GA14900@aniel.lan> <4B684273.6040500@infradead.org> <20100203141210.GD7946@aniel.lan> In-Reply-To: <20100203141210.GD7946@aniel.lan> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Janne Grunau wrote: > Hej, > > On Tue, Feb 02, 2010 at 01:19:15PM -0200, Mauro Carvalho Chehab wrote: >> Janne Grunau wrote: >>> On Fri, Sep 11, 2009 at 06:21:35PM +0200, Julia Lawall wrote: >>>> Error handling code following a kzalloc should free the allocated data. >>> Thanks for the report. I'll commit a different patch which adds the buffer >>> to the buffer list as soon it is allocated. The hdpvr_free_buffers() in the >>> error handling code will clean it up then. See below: >> Any news about this subject? The current upstream code still misses the change bellow > > it was fixed differently in cd0e280f Thanks! I'm removing it from my queue :) Now, the only hdpvr patch is this one: hdpvr-video: cleanup signedness http://patchwork.kernel.org/patch/74902 Cheers, Mauro