All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
To: "Kleen, Andi" <andi.kleen@intel.com>
Cc: "lmr@redhat.com" <lmr@redhat.com>,
	"Li, Haicheng" <haicheng.li@intel.com>,
	Max Asbock <masbock@linux.vnet.ibm.com>,
	"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
	"Zheng, Jiajia" <jiajia.zheng@intel.com>,
	"You, Yongkang" <yongkang.you@intel.com>,
	"avi@redhat.com" <avi@redhat.com>
Subject: Re: [Qemu-devel] [Patch] Support translating Guest physical	address to Host virtual address.
Date: Wed, 03 Feb 2010 10:14:23 -0600	[thread overview]
Message-ID: <4B69A0DF.4040908@linux.vnet.ibm.com> (raw)
In-Reply-To: <46D41A8912DCCF4FB93FA509BD00C63101E79E14@irsmsx002.ger.corp.intel.com>

On 02/03/2010 09:49 AM, Kleen, Andi wrote:
>    
>> Yeah, but if we put a feature in qemu, we need to be able to
>> support it
>> for anyone who wants to use it.
>>      
> It's useful for anyone who wants to use it for testing purposes.
> And it's useful to make sure the qemu/kernel/kvm machine check
> injection code works.
>
>    
>> Adding something for a very particular test suite that won't work in
>> normal circumstances is just asking for trouble IMHO.
>>      
> RAS features generally need associated testing/injection hooks,
> otherwise they don't get tested regularly enough and bitrot.
>
>    
>> I still don't really understand all the pieces that are
>> involved here.
>> Why do we need a guest physical address?  Are we testing
>> reflecting MCEs
>>      
> >from the host into a guest?  Since that functionality isn't in qemu
>    
>> aren't we putting the cart before the horse here?
>>      
> qemu has support for triggering MCEs on the monitor.
>
> Also the KVM code base has support for forwarding the MCEs automatically.
>    

KVM has all of the information you need (guest physical -> host physical 
mapping).  It can also pin the mapping making it much safer to interface 
at that level.  You should probably add an ioctl interface to KVM to get 
a host physical from a given guest physical and then use that to do the 
MCE injection.  You would need to write a little helper tool and you 
would need a way to get an fd for an existing guest.

Regards,

Anthony Liguori

But then it's not a user visible interface.

> -Andi
>    

  reply	other threads:[~2010-02-03 16:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-27  3:25 [Qemu-devel] [Patch] Support translating Guest physical address to Host virtual address Zheng, Jiajia
2010-01-27 21:39 ` Anthony Liguori
2010-01-27 22:31   ` Max Asbock
2010-02-03  4:04     ` Zheng, Jiajia
2010-02-03 13:41       ` Anthony Liguori
2010-02-03 14:11         ` Kleen, Andi
2010-02-03 14:23           ` Anthony Liguori
2010-02-03 15:29             ` Lucas Meneghel Rodrigues
2010-02-03 15:49             ` Kleen, Andi
2010-02-03 16:14               ` Anthony Liguori [this message]
2010-02-05  2:07                 ` Zheng, Jiajia
2010-02-07 14:03                 ` Avi Kivity
2010-02-07 16:23                   ` Anthony Liguori
2010-02-07 16:31                     ` Avi Kivity
2010-02-07 22:09                       ` Anthony Liguori
2010-02-08  3:38                         ` Zheng, Jiajia
2010-02-08  8:43                         ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B69A0DF.4040908@linux.vnet.ibm.com \
    --to=aliguori@linux.vnet.ibm.com \
    --cc=andi.kleen@intel.com \
    --cc=avi@redhat.com \
    --cc=haicheng.li@intel.com \
    --cc=jiajia.zheng@intel.com \
    --cc=lmr@redhat.com \
    --cc=masbock@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yongkang.you@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.