Re: [PATCH 2/3] trace-cmd: fix printf compile warnings

[Darren Hart <dvhltc@us.ibm.com>]

Steven Rostedt wrote:
> On Wed, 2010-02-03 at 17:07 +0100, John Kacur wrote:
>> On Mon, Feb 1, 2010 at 5:50 PM, Darren Hart <dvhltc@us.ibm.com> wrote:
>>> Signed-off-by: Darren Hart <dvhltc@us.ibm.com>
>>> ---
>>>  trace-read.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/trace-read.c b/trace-read.c
>>> index a04c85b..5befaba 100644
>>> --- a/trace-read.c
>>> +++ b/trace-read.c
>>> @@ -216,7 +216,7 @@ static void read_rest(void)
>>>                r = read(input_fd, buf, BUFSIZ);
>>>                if (r > 0) {
>>>                        buf[r] = 0;
>>> -                       printf(buf);
>>> +                       printf("%s", buf);
>>>                }
>>>        } while (r > 0);
>>>  }
>>> --
>>> 1.6.3.3
>>>
>> Oh! Obviously correct, thanks Darren.
> 
> Of the three patches, I think this is the only one that is correct ;-)

The other appear to depend on the guint arch specific implementation of 
the guint64 type, so the only way to fix it with a cast to ull - or to 
not use g types at all. Bleh.

-- 
Darren Hart
IBM Linux Technology Center
Real-Time Linux Team