From: Anthony Liguori <anthony@codemonkey.ws>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] monitor: Use QERR_INVALID_PARAMETER instead of QERR_INVALID_CPU_INDEX
Date: Wed, 03 Feb 2010 12:50:13 -0600 [thread overview]
Message-ID: <4B69C565.9020006@codemonkey.ws> (raw)
In-Reply-To: <1264757641-29471-2-git-send-email-armbru@redhat.com>
On 01/29/2010 03:34 AM, Markus Armbruster wrote:
> This changes the error message from "Invalid CPU index" to "Invalid
> parameter index" in the human monitor.
>
> Signed-off-by: Markus Armbruster<armbru@redhat.com>
>
Applied both. Thanks.
Regards,
Anthony Liguori
> ---
> monitor.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index fb7c572..69ebac5 100644
> --- a/monitor.c
> +++ b/monitor.c
> @@ -897,7 +897,7 @@ static void do_cpu_set(Monitor *mon, const QDict *qdict, QObject **ret_data)
> {
> int index = qdict_get_int(qdict, "index");
> if (mon_set_cpu(index)< 0)
> - qemu_error_new(QERR_INVALID_CPU_INDEX);
> + qemu_error_new(QERR_INVALID_PARAMETER, "index");
> }
>
> static void do_info_jit(Monitor *mon)
>
next prev parent reply other threads:[~2010-02-03 18:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 9:33 [Qemu-devel] [PATCH 0/2] Avoid extra error for do_cpu_set() Markus Armbruster
2010-01-29 9:34 ` [Qemu-devel] [PATCH 1/2] monitor: Use QERR_INVALID_PARAMETER instead of QERR_INVALID_CPU_INDEX Markus Armbruster
2010-02-03 18:50 ` Anthony Liguori [this message]
2010-01-29 9:34 ` [Qemu-devel] [PATCH 2/2] Revert "QError: New QERR_INVALID_CPU_INDEX" Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B69C565.9020006@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.