From: Jeff Garzik <jeff@garzik.org>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>
Subject: Re: [Patch] tabled: replace event_loopbreak with pipe
Date: Thu, 04 Feb 2010 00:19:36 -0500 [thread overview]
Message-ID: <4B6A58E8.7070904@garzik.org> (raw)
In-Reply-To: <20100203200207.6235b8d9@redhat.com>
On 02/03/2010 10:02 PM, Pete Zaitcev wrote:
> As it turned out, event_loopbreak() does not awaken the thread that
> exectutes event_dispatch(), but our code expected that it would.
> One easily noticeable effect was that there was a noticeable delay
> between the state transition to DB master and listening on sockets.
> I knew the mysterious delay existed for a while, but never got around
> to investigate. For ncld API, I moved the processing of CLD packets
> to its own thread and suddenly everything else froze. Apparently the
> existing code only works because of extra packets of CLD protocol.
>
> For a fix, dispose of event_loopbreak and use a loopback pipe.
> Also gone is state_tdb_new. That thing was just disgusting.
>
> Notice that we still have one event_loopbreak remaining, because it
> works correctly thanks to UNIX signal awakening the polling thread.
>
> Signed-Off-By: Pete Zaitcev<zaitcev@redhat.com>
applied, with a few cosmetic changes (speling correction, use of 'switch')
prev parent reply other threads:[~2010-02-04 5:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 3:02 [Patch] tabled: replace event_loopbreak with pipe Pete Zaitcev
2010-02-04 5:19 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6A58E8.7070904@garzik.org \
--to=jeff@garzik.org \
--cc=hail-devel@vger.kernel.org \
--cc=zaitcev@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.