From: Michal Marek <mmarek@suse.cz>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: ak@linux.intel.com, linuxppc-dev@ozlabs.org,
akpm@linux-foundation.org, andi@firstfloor.org, kyle@mcmartin.ca
Subject: Re: [patch 2/2] kbuild: move -fno-dwarf2-cfi-asm to powerpc only
Date: Thu, 04 Feb 2010 14:03:03 +0100 [thread overview]
Message-ID: <4B6AC587.5060608@suse.cz> (raw)
In-Reply-To: <1265239339.8287.126.camel@pasglop>
On 4.2.2010 00:22, Benjamin Herrenschmidt wrote:
> On Tue, 2010-02-02 at 14:40 -0800, akpm@linux-foundation.org wrote:
>> From: Andi Kleen <andi@firstfloor.org>
>>
>> Better dwarf2 unwind information is a good thing, it allows better
>> debugging with kgdb and crash and helps systemtap.
>>
>> Commit 003086497f07f7f1e67c0c295e261740f822b377 ("Build with
>> -fno-dwarf2-cfi-asm") disabled some CFI information globally to work
>> around a module loader bug on powerpc.
>>
>> But this disables the better unwind tables for all architectures, not just
>> powerpc. Move the workaround to powerpc and also add a suitable comment
>> that's it really a workaround.
>>
>> This improves dwarf2 unwind tables on x86 at least.
>>
>> Signed-off-by: Andi Kleen <ak@linux.intel.com>
>> Cc: Kyle McMartin <kyle@mcmartin.ca>
>
> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> Do you want me to carry that in powerpc-next ?
I can add it to kbuild-next. Changes to the top-level Makefile usually
go through kbuild, so it will avoid potential conflicts.
Michal
prev parent reply other threads:[~2010-02-04 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-02 22:40 [patch 2/2] kbuild: move -fno-dwarf2-cfi-asm to powerpc only akpm
2010-02-03 23:22 ` Benjamin Herrenschmidt
2010-02-04 13:03 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6AC587.5060608@suse.cz \
--to=mmarek@suse.cz \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=benh@kernel.crashing.org \
--cc=kyle@mcmartin.ca \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.