From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: lvm-devel@redhat.com
Subject: New clvmd init script
Date: Thu, 04 Feb 2010 15:54:07 +0100 [thread overview]
Message-ID: <4B6ADF8F.9040203@redhat.com> (raw)
Hi guys,
Started from https://bugzilla.redhat.com/show_bug.cgi?id=533247
- fix whitespaces all over (tabs/spaces)
- use secure path
- remove hardcoding of paths for tools
- increase timeout to 30 secs (on Chrissie request)
- source both cluster and clvmd for options (like all the other cluster
init scripts)
- add clustered_vgs and _lvs commodity fns
- move rh_status* fns at the top, so they can be reused
- heavily cleanup start and stop fns from redundant code and unnecessary
loops
- drop wait_for_finish. According to docs killproc will send first
specified signals and then SIGKILL and do the way for us.
- improve output from status
- make the init script lsb compliant
Please review and let me know if we need to add more changes.
Both Chrissie and I have tested this new version.
Fabio
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: clvmd_init.diff
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20100204/70cabc5c/attachment.ksh>
reply other threads:[~2010-02-04 14:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B6ADF8F.9040203@redhat.com \
--to=fdinitto@redhat.com \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.